Remove unnecessary calls to GURL()

chrome/browser/net/predictor_unittest.cc

Index: chrome/browser/net/predictor_unittest.cc
diff --git a/chrome/browser/net/predictor_unittest.cc b/chrome/browser/net/predictor_unittest.cc
index 9b947c0b02e020f9eb980862a5513558d3b7e554..30c1ca5e37e1dbacf3872e0a4fe0f02d527173ee 100644
--- a/chrome/browser/net/predictor_unittest.cc
+++ b/chrome/browser/net/predictor_unittest.cc
@@ -67,7 +67,7 @@ static const base::ListValue* FindSerializationMotivation(
     referral_list->GetList(i, &motivation_list);
     std::string existing_spec;
     EXPECT_TRUE(motivation_list->GetString(0, &existing_spec));
-    if (motivation == GURL(existing_spec))
+    if (motivation == existing_spec)

[Charlie Harrison, 2016/11/09 21:12:58]

Let's keep the GURL() here, or at least DCHECK that GURL(existing_spec) ==
existing_spec.

[cfredric, 2016/11/09 22:12:46]

Done.

       return motivation_list;
   }
   return NULL;
@@ -138,7 +138,7 @@ static bool GetDataFromSerialization(const GURL& motivation,
     std::string url_spec;
     EXPECT_TRUE(subresource_list->GetString(i++, &url_spec));
     EXPECT_TRUE(subresource_list->GetDouble(i++, use_rate));
-    if (subresource == GURL(url_spec)) {
+    if (subresource == url_spec) {

[Charlie Harrison, 2016/11/09 21:12:58]

same here. I'm generally nervous about using this operator on dynamic values.

[cfredric, 2016/11/09 22:12:46]

Done.

       return true;
     }
   }