Remove unnecessary calls to GURL()

chrome/browser/net/predictor_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/net/predictor.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <memory>
@@ skipping 49 matching lines @@
     const base::ListValue* referral_list) {
   CHECK_LT(0u, referral_list->GetSize());  // Room for version.
   int format_version = -1;
   CHECK(referral_list->GetInteger(0, &format_version));
   CHECK_EQ(Predictor::kPredictorReferrerVersion, format_version);
   const base::ListValue* motivation_list(NULL);
   for (size_t i = 1; i < referral_list->GetSize(); ++i) {
     referral_list->GetList(i, &motivation_list);
     std::string existing_spec;
     EXPECT_TRUE(motivation_list->GetString(0, &existing_spec));
-    if (motivation == GURL(existing_spec))
+    if (motivation == existing_spec)

[Charlie Harrison, 2016/11/09 21:12:58]

Let's keep the GURL() here, or at least DCHECK that GURL(existing_spec) ==
existing_spec.

[cfredric, 2016/11/09 22:12:46]

Done.

       return motivation_list;
   }
   return NULL;
 }
 
 static base::ListValue* FindSerializationMotivation(
     const GURL& motivation,
     base::ListValue* referral_list) {
   return const_cast<base::ListValue*>(FindSerializationMotivation(
       motivation, static_cast<const base::ListValue*>(referral_list)));
@@ skipping 50 matching lines @@
   const base::ListValue* motivation_list =
       FindSerializationMotivation(motivation, &referral_list);
   if (!motivation_list)
     return false;
   const base::ListValue* subresource_list;
   EXPECT_TRUE(motivation_list->GetList(1, &subresource_list));
   for (size_t i = 0; i < subresource_list->GetSize();) {
     std::string url_spec;
     EXPECT_TRUE(subresource_list->GetString(i++, &url_spec));
     EXPECT_TRUE(subresource_list->GetDouble(i++, use_rate));
-    if (subresource == GURL(url_spec)) {
+    if (subresource == url_spec) {

[Charlie Harrison, 2016/11/09 21:12:58]

same here. I'm generally nervous about using this operator on dynamic values.

[cfredric, 2016/11/09 22:12:46]

Done.

       return true;
     }
   }
   return false;
 }
 
 TEST_F(PredictorTest, StartupShutdownTest) {
   Predictor testing_master(true);
   testing_master.Shutdown();
 }
@@ skipping 408 matching lines @@
   testing_master.Resolve(goog, UrlInfo::OMNIBOX_MOTIVATED);
 
   // Proxy may not be in use (the PAC script has not yet been evaluated), so the
   // name has been registered for pre-resolve.
   EXPECT_FALSE(testing_master.work_queue_.IsEmpty());
 
   testing_master.Shutdown();
 }
 
 }  // namespace chrome_browser_net