Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 248503004: Synchronize attribute before animation ends (Closed)

Created:
6 years, 8 months ago by davve
Modified:
6 years, 8 months ago
Reviewers:
fs
CC:
blink-reviews, ed+blinkwatch_opera.com, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), rwlbuis, fs, kouhei+svg_chromium.org, dstockwell, Timothy Loh, krit, f(malita), gyuyoung.kim_webkit.org, darktears, Stephen Chennney, Steve Block, dino_apple.com, pdr., Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Synchronize attribute before animation ends After https://codereview.chromium.org/26390004, width and height on SVGSVGElement are presentation attributes. When they are animated, they must be synchronized to the attribute system so that the presentation attribute code can rebuild the corresponding style. Prior to this patch, the last synchronization (back to base value or to fill value) never happened because the synchronization happened after the animation had ended. No animation means no synchronization. This patch adds a final synchronization before the animation ends so that the final value is properly synchronized. BUG=308992, 364807 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172353

Patch Set 1 #

Patch Set 2 : Re-upload with --no-find-copies #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -2 lines) Patch
A LayoutTests/svg/custom/animate-svgsvgelement.html View 1 chunk +25 lines, -0 lines 0 comments Download
A LayoutTests/svg/custom/animate-svgsvgelement-expected.txt View 1 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/svg/properties/SVGAnimatedProperty.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/properties/SVGAnimatedProperty.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
davve
fs, you have looked a bit at attribute synchronization before, haven't you? Feel free to ...
6 years, 8 months ago (2014-04-23 09:16:43 UTC) #1
fs
LGTM
6 years, 8 months ago (2014-04-23 09:29:07 UTC) #2
davve
The CQ bit was checked by davve@opera.com
6 years, 8 months ago (2014-04-23 09:32:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davve@opera.com/248503004/20001
6 years, 8 months ago (2014-04-23 09:32:48 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-23 09:39:19 UTC) #5
Message was sent while issue was closed.
Change committed as 172353

Powered by Google App Engine
This is Rietveld 408576698