Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 26390004: Rework SVG sizing (Closed)

Created:
7 years, 2 months ago by davve
Modified:
6 years, 8 months ago
CC:
blink-reviews, zoltan1, eae+blinkwatch, leviw+renderwatch, dglazkov+blink, apavlov+blink_chromium.org, jchaffraix+rendering, darktears, pdr, f(malita), Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Rework SVG sizing The basis of this change is to map explicit width and height attributes to CSS properties, essentially promoting them to presentation attributes. Note that implicit "100%" width and height are not mapped. This enables us to remove the concept of "percentage intrinsic size" and rely on normal CSS rules to resolve percentage values. The change has been approved by the SVG WG and the spec is being updated. Minutes here: http://www.w3.org/2014/04/07-svg-minutes.html#item03 Many of the -expected updates are caused by SVG size changes in turn affecting where line breaks are inserted. BUG=308992 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171958

Patch Set 1 #

Patch Set 2 : Reupload (workaround Rietveld patch mismatch bug) #

Patch Set 3 : Rebased #

Patch Set 4 : Rebased and some tests addressed (more than half to go though) #

Patch Set 5 : Apply default 100% width/height when no intrinsic ratio from viewBox #

Patch Set 6 : Add default width/height for missing viewBox to svg.css instead to get proper ordering #

Patch Set 7 : Rebased and ready for a try test run #

Patch Set 8 : Testsuite update; still WIP #

Patch Set 9 : Fix unittest failure in TouchActionTest.Simple #

Patch Set 10 : More testsuite updates and added test expectations #

Patch Set 11 : More testsuite updates: add tests for <object> and inline svg and remove invalid tests #

Patch Set 12 : Re-upload of previous patch set (got error) #

Patch Set 13 : Minor touch-ups to the tests; only fail now should be crbug.com/363126 #

Total comments: 6

Patch Set 14 : Get rid of position:absolute for stand alone SVG images #

Patch Set 15 : Fix test that was disabled on linux and stand alone svg in error mode #

Total comments: 5

Patch Set 16 : For landing. #

Patch Set 17 : Rebased for landing #

Patch Set 18 : Fix mishap during rebase in svg.css #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+2543 lines, -770 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +28 lines, -0 lines 0 comments Download
M LayoutTests/accessibility/svg-image-expected.txt View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/css3/flexbox/flexitem.html View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css/remove-fixed-resizer-crash-expected.txt View 1 2 3 5 6 7 8 9 10 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/innerHTML/innerHTML-xml-expected.txt View 1 2 3 5 6 7 8 9 10 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/repaint/svg-layout-root-style-attr-update.html View 1 2 3 4 5 6 7 8 9 10 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/shapes/shape-outside-floats/shape-outside-relative-size-svg.html View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/shapes/shape-outside-floats/shape-outside-relative-size-svg-expected.html View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/svg/different-overflow-values-expected.txt View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/xmlviewer/dumpAsText/svg-expected.txt View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/win/svg/custom/external-paintserver-reference-expected.txt View 1 2 3 5 6 7 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/svg/animations/multiple-begin-animation-events.html View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/svg/as-image/image-respects-deviceScaleFactor.html View 1 2 3 5 6 7 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/svg/as-image/image-respects-pageScaleFactor.html View 1 2 3 4 5 6 7 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/svg/as-image/svg-as-image-with-relative-size-expected.html View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/svg/as-image/svg-as-relative-image.html View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
A LayoutTests/svg/as-object/sizing/svg-in-object.js View 1 2 3 4 5 6 7 8 9 10 1 chunk +461 lines, -0 lines 0 comments Download
A LayoutTests/svg/as-object/sizing/svg-in-object-placeholder-height-auto.html View 1 2 3 4 5 6 7 8 9 10 1 chunk +28 lines, -0 lines 0 comments Download
A LayoutTests/svg/as-object/sizing/svg-in-object-placeholder-height-auto-expected.txt View 1 2 3 4 5 6 7 8 9 10 1 chunk +219 lines, -0 lines 0 comments Download
A LayoutTests/svg/as-object/sizing/svg-in-object-placeholder-height-fixed.html View 1 2 3 4 5 6 7 8 9 10 1 chunk +28 lines, -0 lines 0 comments Download
A LayoutTests/svg/as-object/sizing/svg-in-object-placeholder-height-fixed-expected.txt View 1 2 3 4 5 6 7 8 9 10 1 chunk +219 lines, -0 lines 0 comments Download
A LayoutTests/svg/as-object/sizing/svg-in-object-placeholder-height-percentage.html View 1 2 3 4 5 6 7 8 9 10 1 chunk +28 lines, -0 lines 0 comments Download
A LayoutTests/svg/as-object/sizing/svg-in-object-placeholder-height-percentage-expected.txt View 1 2 3 4 5 6 7 8 9 10 1 chunk +219 lines, -0 lines 0 comments Download
M LayoutTests/svg/css/max-width-2.html View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/svg/custom/absolute-sized-content-with-resources.xhtml View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/svg/custom/altglyph.svg View 1 2 3 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/svg/custom/document-all-includes-svg-expected.txt View 1 2 3 4 5 6 7 8 9 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/svg/custom/external-paintserver-reference.svg View 1 2 3 4 5 6 7 8 9 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/svg/custom/get-text-element-transform-crash-expected.txt View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/svg/custom/linking-base-external-reference.xhtml View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
D LayoutTests/svg/custom/object-sizing-height-50p-on-target-svg.xhtml View 1 2 3 4 5 6 7 8 9 10 1 chunk +0 lines, -26 lines 0 comments Download
D LayoutTests/svg/custom/object-sizing-height-50p-on-target-svg-absolute.xhtml View 1 2 3 4 5 6 7 8 9 10 1 chunk +0 lines, -26 lines 0 comments Download
D LayoutTests/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.txt View 1 2 3 4 5 6 7 8 9 10 1 chunk +0 lines, -20 lines 0 comments Download
D LayoutTests/svg/custom/object-sizing-height-50p-on-target-svg-expected.txt View 1 2 3 4 5 6 7 8 9 10 1 chunk +0 lines, -20 lines 0 comments Download
D LayoutTests/svg/custom/object-sizing-width-50p-height-50p-on-target-svg.xhtml View 1 2 3 4 5 6 7 8 9 10 1 chunk +0 lines, -26 lines 0 comments Download
D LayoutTests/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute.xhtml View 1 2 3 4 5 6 7 8 9 10 1 chunk +0 lines, -26 lines 0 comments Download
D LayoutTests/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt View 1 2 3 4 5 6 7 8 9 10 1 chunk +0 lines, -20 lines 0 comments Download
D LayoutTests/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.txt View 1 2 3 4 5 6 7 8 9 10 1 chunk +0 lines, -20 lines 0 comments Download
D LayoutTests/svg/custom/object-sizing-width-50p-height-75p-on-target-svg.xhtml View 1 2 3 4 5 6 7 8 9 10 1 chunk +0 lines, -26 lines 0 comments Download
D LayoutTests/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute.xhtml View 1 2 3 4 5 6 7 8 9 10 1 chunk +0 lines, -26 lines 0 comments Download
D LayoutTests/svg/custom/object-sizing-width-50p-on-target-svg.xhtml View 1 2 3 4 5 6 7 8 9 10 1 chunk +0 lines, -26 lines 0 comments Download
D LayoutTests/svg/custom/object-sizing-width-50p-on-target-svg-absolute.xhtml View 1 2 3 4 5 6 7 8 9 10 1 chunk +0 lines, -26 lines 0 comments Download
D LayoutTests/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt View 1 2 3 4 5 6 7 8 9 10 1 chunk +0 lines, -20 lines 0 comments Download
D LayoutTests/svg/custom/object-sizing-width-50p-on-target-svg-expected.txt View 1 2 3 4 5 6 7 8 9 10 1 chunk +0 lines, -20 lines 0 comments Download
D LayoutTests/svg/custom/object-sizing-width-75p-height-50p-on-target-svg.xhtml View 1 2 3 4 5 6 7 8 9 10 1 chunk +0 lines, -26 lines 0 comments Download
D LayoutTests/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute.xhtml View 1 2 3 4 5 6 7 8 9 10 1 chunk +0 lines, -26 lines 0 comments Download
D LayoutTests/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt View 1 2 3 4 5 6 7 8 9 10 1 chunk +0 lines, -20 lines 0 comments Download
M LayoutTests/svg/custom/path-arc-invalid-expected.txt View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/svg/custom/pending-resource-after-removal.xhtml View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/svg/custom/percentage-of-html-parent.xhtml View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/svg/custom/relative-sized-content.xhtml View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/svg/custom/relative-sized-content-with-resources.xhtml View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/svg/custom/relative-sized-deep-shadow-tree-content.xhtml View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/svg/custom/relative-sized-image.xhtml View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/svg/custom/relative-sized-inner-svg.xhtml View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/svg/custom/relative-sized-shadow-tree-content.xhtml View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/svg/custom/relative-sized-shadow-tree-content-with-symbol.xhtml View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/svg/custom/relative-sized-use-on-symbol.xhtml View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/svg/custom/relative-sized-use-without-attributes-on-symbol.xhtml View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/svg/custom/tref-with-progress-tag-setpseudo-assert-expected.txt View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/svg/custom/unicode-in-tspan-multi-svg-crash-expected.txt View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/svg/custom/use-invalid-html-expected.txt View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/svg/custom/window-named-item-lookup-expected.txt View 1 2 3 4 5 6 7 8 9 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/svg/dom/parent-view-layout-crash-expected.txt View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/svg/dom/stylesheet-candidate-node-crash-main-expected.txt View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/svg/dom/svg-root-lengths.html View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/svg/foreignObject/absolute-position-foreign-object-child-crash-expected.txt View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
D LayoutTests/svg/hixie/intrinsic/001.html View 1 2 3 4 5 6 7 8 9 10 1 chunk +0 lines, -15 lines 0 comments Download
D LayoutTests/svg/hixie/intrinsic/001-expected.txt View 1 2 3 4 5 6 7 8 9 10 1 chunk +0 lines, -15 lines 0 comments Download
D LayoutTests/svg/hixie/intrinsic/002.html View 1 2 3 4 5 6 7 8 9 10 1 chunk +0 lines, -17 lines 0 comments Download
D LayoutTests/svg/hixie/intrinsic/002-expected.txt View 1 2 3 4 5 6 7 8 9 10 1 chunk +0 lines, -17 lines 0 comments Download
D LayoutTests/svg/hixie/intrinsic/resources/001.svg View 1 2 3 4 5 6 7 8 9 10 1 chunk +0 lines, -3 lines 0 comments Download
D LayoutTests/svg/hixie/intrinsic/resources/002.svg View 1 2 3 4 5 6 7 8 9 10 1 chunk +0 lines, -3 lines 0 comments Download
A LayoutTests/svg/in-html/sizing/svg-inline.html View 1 2 3 4 5 6 7 8 9 10 1 chunk +27 lines, -0 lines 0 comments Download
A LayoutTests/svg/in-html/sizing/svg-inline.js View 1 2 3 4 5 6 7 8 9 10 1 chunk +428 lines, -0 lines 0 comments Download
A LayoutTests/svg/in-html/sizing/svg-inline-expected.txt View 1 2 3 4 5 6 7 8 9 10 1 chunk +651 lines, -0 lines 0 comments Download
M LayoutTests/svg/text/append-text-node-to-tspan.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/svg/text/kerning.svg View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/svg/text/modify-text-node-in-tspan.html View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/svg/text/multichar-glyph.svg View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/svg/text/remove-text-node-from-tspan.html View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/svg/text/remove-tspan-from-text.html View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/svg/text/svg-rtl-text-crash-expected.txt View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/svg/text/text-block-child-crash-expected.txt View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/svg/text/text-layout-crash-expected.txt View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/svg/transforms/animated-path-inside-transformed-html.xhtml View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/svg/transforms/svg-css-transforms-clip-path.xhtml View 1 2 3 4 5 6 7 8 9 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/svg/transforms/transform-origin-css-property.xhtml View 1 2 3 4 5 6 7 8 9 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/svg/zoom/page/zoom-foreignObject.svg View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/svg/zoom/page/zoom-svg-as-relative-image.html View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/svg/zoom/page/zoom-svg-as-relative-image-expected.txt View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/svg/zoom/text/zoom-foreignObject.svg View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/svg.css View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +5 lines, -0 lines 2 comments Download
M Source/core/rendering/RenderBox.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderBoxModelObject.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 2 chunks +8 lines, -11 lines 0 comments Download
M Source/core/rendering/RenderImage.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderImage.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderReplaced.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 3 chunks +2 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderReplaced.cpp View 1 2 3 4 5 6 7 9 chunks +22 lines, -37 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGRoot.h View 1 2 3 4 5 6 7 2 chunks +1 line, -4 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGRoot.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 5 chunks +23 lines, -69 lines 0 comments Download
M Source/core/svg/SVGSVGElement.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 3 chunks +6 lines, -10 lines 0 comments Download
M Source/core/svg/SVGSVGElement.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 3 chunks +56 lines, -78 lines 0 comments Download
M Source/core/svg/graphics/SVGImage.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/svg/graphics/SVGImage.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 2 chunks +1 line, -17 lines 0 comments Download
M Source/core/xml/XMLErrors.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +6 lines, -0 lines 0 comments Download
M Source/web/tests/data/touch-action-simple.html View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 33 (0 generated)
ojan
This looks great. We should absolutely do this. Do all the tests pass?
6 years, 9 months ago (2014-03-19 20:17:48 UTC) #1
davve
On 2014/03/19 20:17:48, ojan wrote: > This looks great. We should absolutely do this. Do ...
6 years, 9 months ago (2014-03-20 07:35:00 UTC) #2
pdr.
On 2014/03/20 07:35:00, David Vest wrote: > On 2014/03/19 20:17:48, ojan wrote: > > This ...
6 years, 9 months ago (2014-03-21 17:19:20 UTC) #3
davve
> Can you summarize the changes for authors here and how it will > differ ...
6 years, 9 months ago (2014-03-24 08:29:52 UTC) #4
davve
> Let's modify the example above with a viewBox attribute: > > <div style="width:100px;height:100px"> > ...
6 years, 9 months ago (2014-03-24 10:07:22 UTC) #5
pdr.
I saw this was recently updated :) Ready for a review yet? I noticed there ...
6 years, 8 months ago (2014-04-15 02:46:10 UTC) #6
fs
https://codereview.chromium.org/26390004/diff/244001/LayoutTests/accessibility/svg-image-expected.txt File LayoutTests/accessibility/svg-image-expected.txt (right): https://codereview.chromium.org/26390004/diff/244001/LayoutTests/accessibility/svg-image-expected.txt#newcode1 LayoutTests/accessibility/svg-image-expected.txt:1: I noticed that there's a lot of these "stray ...
6 years, 8 months ago (2014-04-15 09:01:24 UTC) #7
Erik Dahlström (inactive)
https://codereview.chromium.org/26390004/diff/244001/LayoutTests/svg/in-html/sizing/svg-inline.js File LayoutTests/svg/in-html/sizing/svg-inline.js (right): https://codereview.chromium.org/26390004/diff/244001/LayoutTests/svg/in-html/sizing/svg-inline.js#newcode369 LayoutTests/svg/in-html/sizing/svg-inline.js:369: doCombinationTest( shouldn't there be tests for explicit 'auto' and ...
6 years, 8 months ago (2014-04-15 09:37:42 UTC) #8
davve
> I saw this was recently updated :) Ready for a review yet? I think ...
6 years, 8 months ago (2014-04-15 15:55:09 UTC) #9
davve
https://codereview.chromium.org/26390004/diff/244001/LayoutTests/svg/in-html/sizing/svg-inline.js File LayoutTests/svg/in-html/sizing/svg-inline.js (right): https://codereview.chromium.org/26390004/diff/244001/LayoutTests/svg/in-html/sizing/svg-inline.js#newcode369 LayoutTests/svg/in-html/sizing/svg-inline.js:369: doCombinationTest( On 2014/04/15 09:37:43, Erik Dahlström wrote: > shouldn't ...
6 years, 8 months ago (2014-04-15 15:55:23 UTC) #10
davve
Filed crbug.com/364051 and crbug.com/363949 on issues we might want to fix in follow-up patches. Neither ...
6 years, 8 months ago (2014-04-16 14:35:29 UTC) #11
pdr.
LGTM with two minor nits. https://codereview.chromium.org/26390004/diff/284001/Source/core/svg/SVGSVGElement.cpp File Source/core/svg/SVGSVGElement.cpp (right): https://codereview.chromium.org/26390004/diff/284001/Source/core/svg/SVGSVGElement.cpp#newcode295 Source/core/svg/SVGSVGElement.cpp:295: if (outermost && (name ...
6 years, 8 months ago (2014-04-16 18:17:03 UTC) #12
davve
https://codereview.chromium.org/26390004/diff/284001/Source/core/svg/SVGSVGElement.cpp File Source/core/svg/SVGSVGElement.cpp (right): https://codereview.chromium.org/26390004/diff/284001/Source/core/svg/SVGSVGElement.cpp#newcode295 Source/core/svg/SVGSVGElement.cpp:295: if (outermost && (name == SVGNames::widthAttr || name == ...
6 years, 8 months ago (2014-04-17 11:39:22 UTC) #13
pdr.
On 2014/04/17 11:39:22, David Vest wrote: > https://codereview.chromium.org/26390004/diff/284001/Source/core/svg/SVGSVGElement.cpp > File Source/core/svg/SVGSVGElement.cpp (right): > > https://codereview.chromium.org/26390004/diff/284001/Source/core/svg/SVGSVGElement.cpp#newcode295 ...
6 years, 8 months ago (2014-04-17 21:49:08 UTC) #14
davve
On 2014/04/17 21:49:08, pdr wrote: > On 2014/04/17 11:39:22, David Vest wrote: > > > ...
6 years, 8 months ago (2014-04-18 09:42:06 UTC) #15
davve
The CQ bit was checked by davve@opera.com
6 years, 8 months ago (2014-04-18 09:45:10 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davve@opera.com/26390004/304001
6 years, 8 months ago (2014-04-18 09:45:18 UTC) #17
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-18 09:46:02 UTC) #18
commit-bot: I haz the power
Failed to apply patch for Source/core/svg/graphics/SVGImage.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 8 months ago (2014-04-18 09:46:02 UTC) #19
davve
The CQ bit was checked by davve@opera.com
6 years, 8 months ago (2014-04-18 10:31:00 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davve@opera.com/26390004/324001
6 years, 8 months ago (2014-04-18 10:31:09 UTC) #21
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-18 10:48:31 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on blink_presubmit
6 years, 8 months ago (2014-04-18 10:48:32 UTC) #23
davve
Ojan, do you think you can review Source/web/?
6 years, 8 months ago (2014-04-18 14:28:42 UTC) #24
davve
(Not sure who works on a Good Friday...) Or Adam, perhaps you could review Source/web?
6 years, 8 months ago (2014-04-18 16:04:36 UTC) #25
eseidel
I don't really fully understand this change. I take it the SVG spec changed? In ...
6 years, 8 months ago (2014-04-18 16:12:48 UTC) #26
davve
Yes, the SVG WG has a resolution to make changes corresponding to the CL. I ...
6 years, 8 months ago (2014-04-18 17:24:31 UTC) #27
davve
The CQ bit was checked by davve@opera.com
6 years, 8 months ago (2014-04-18 17:26:35 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davve@opera.com/26390004/344001
6 years, 8 months ago (2014-04-18 17:26:47 UTC) #29
commit-bot: I haz the power
Change committed as 171958
6 years, 8 months ago (2014-04-18 17:46:09 UTC) #30
commit-bot: I haz the power
Failed to apply patch for LayoutTests/accessibility/svg-image-expected.txt: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 8 months ago (2014-04-18 17:46:49 UTC) #31
eae
This change cased a bunch of SVG tests to start timing out: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20Blink&tests=svg%2Fas-object%2Fsizing%2Fsvg-in-object-placeholder-height-fixed.html%20svg%2Fas-object%2Fsizing%2Fsvg-in-object-placeholder-height-auto.html%20svg%2Fas-object%2Fsizing%2Fsvg-in-object-placeholder-height-percentage.html
6 years, 8 months ago (2014-04-18 22:01:22 UTC) #32
eae
6 years, 8 months ago (2014-04-18 22:02:15 UTC) #33
Message was sent while issue was closed.
On 2014/04/18 22:01:22, eae wrote:
> This change cased a bunch of SVG tests to start timing out:
> 
>
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40...

As they are new tests added by this change I'll mark them as [ Timeout ] for
now. Please look into it and rework the tests if needed though.

Powered by Google App Engine
This is Rietveld 408576698