Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(692)

Side by Side Diff: Source/core/svg/properties/SVGAnimatedProperty.cpp

Issue 248503004: Synchronize attribute before animation ends (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Re-upload with --no-find-copies Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/svg/properties/SVGAnimatedProperty.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
55 } 55 }
56 56
57 void SVGAnimatedPropertyBase::animationStarted() 57 void SVGAnimatedPropertyBase::animationStarted()
58 { 58 {
59 ASSERT(!isAnimating()); 59 ASSERT(!isAnimating());
60 m_isAnimating = true; 60 m_isAnimating = true;
61 } 61 }
62 62
63 void SVGAnimatedPropertyBase::animationEnded() 63 void SVGAnimatedPropertyBase::animationEnded()
64 { 64 {
65 synchronizeAttribute();
65 ASSERT(isAnimating()); 66 ASSERT(isAnimating());
66 m_isAnimating = false; 67 m_isAnimating = false;
67 } 68 }
68 69
69 void SVGAnimatedPropertyBase::synchronizeAttribute() 70 void SVGAnimatedPropertyBase::synchronizeAttribute()
70 { 71 {
71 ASSERT(needsSynchronizeAttribute()); 72 ASSERT(needsSynchronizeAttribute());
72 AtomicString value(currentValueBase()->valueAsString()); 73 AtomicString value(currentValueBase()->valueAsString());
73 m_contextElement->setSynchronizedLazyAttribute(m_attributeName, value); 74 m_contextElement->setSynchronizedLazyAttribute(m_attributeName, value);
74 } 75 }
75 76
76 bool SVGAnimatedPropertyBase::isSpecified() const 77 bool SVGAnimatedPropertyBase::isSpecified() const
77 { 78 {
78 return isAnimating() || contextElement()->hasAttribute(attributeName()); 79 return isAnimating() || contextElement()->hasAttribute(attributeName());
79 } 80 }
80 81
81 } // namespace WebCore 82 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/svg/properties/SVGAnimatedProperty.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698