base/BUILD.gn - Issue 2484803003: Move WTF::SpinLock to base::SpinLock.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/BUILD.gn

Issue 2484803003: Move WTF::SpinLock to base::SpinLock. (Closed)

Patch Set: Rebase and fix build (NaCl can't have inline assembly). Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/BUILD.gn

diff --git a/base/BUILD.gn b/base/BUILD.gn

index 47ee8fa6aed558d1c468483428b0bad932d76901..28b50b93842daabc6183dd2ff0a5df60f4c50e35 100644

--- a/base/BUILD.gn

+++ b/base/BUILD.gn

@@ -1201,6 +1201,14 @@ component("base") {

"rand_util_nacl.cc",

"synchronization/read_write_lock_nacl.cc",

]

+ # Add stuff that doesn't work in NaCl.

+ sources += [

+ # SpinLock uses GNU-style inline assembly, which the pnacl-clang++

+ # compiler doesn't allow.

dcheng 2016/11/15 02:46:03 Will we need to move things like LazyInstance and

+ "synchronization/spin_lock.cc",

+ "synchronization/spin_lock.h",

+ ]

}

# Windows.

« no previous file with comments | « no previous file | base/synchronization/spin_lock.h » ('j') | no next file with comments »