Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Side by Side Diff: base/BUILD.gn

Issue 2484803003: Move WTF::SpinLock to base::SpinLock. (Closed)
Patch Set: Rebase and fix build (NaCl can't have inline assembly). Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | base/synchronization/spin_lock.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # HOW TO WRITE CONDITIONALS IN THIS FILE 5 # HOW TO WRITE CONDITIONALS IN THIS FILE
6 # ====================================== 6 # ======================================
7 # 7 #
8 # In many other places, one would write a conditional that expresses all the 8 # In many other places, one would write a conditional that expresses all the
9 # cases when a source file is used or unused, and then either add or subtract 9 # cases when a source file is used or unused, and then either add or subtract
10 # it from the sources list in that case 10 # it from the sources list in that case
(...skipping 1183 matching lines...) Expand 10 before | Expand all | Expand 10 after
1194 } 1194 }
1195 } else { 1195 } else {
1196 # Remove NaCl stuff. 1196 # Remove NaCl stuff.
1197 sources -= [ 1197 sources -= [
1198 "memory/shared_memory_nacl.cc", 1198 "memory/shared_memory_nacl.cc",
1199 "os_compat_nacl.cc", 1199 "os_compat_nacl.cc",
1200 "os_compat_nacl.h", 1200 "os_compat_nacl.h",
1201 "rand_util_nacl.cc", 1201 "rand_util_nacl.cc",
1202 "synchronization/read_write_lock_nacl.cc", 1202 "synchronization/read_write_lock_nacl.cc",
1203 ] 1203 ]
1204
1205 # Add stuff that doesn't work in NaCl.
1206 sources += [
1207 # SpinLock uses GNU-style inline assembly, which the pnacl-clang++
1208 # compiler doesn't allow.
dcheng 2016/11/15 02:46:03 Will we need to move things like LazyInstance and
1209 "synchronization/spin_lock.cc",
1210 "synchronization/spin_lock.h",
1211 ]
1204 } 1212 }
1205 1213
1206 # Windows. 1214 # Windows.
1207 if (is_win) { 1215 if (is_win) {
1208 sources += [ 1216 sources += [
1209 "power_monitor/power_monitor_device_source_win.cc", 1217 "power_monitor/power_monitor_device_source_win.cc",
1210 "profiler/win32_stack_frame_unwinder.cc", 1218 "profiler/win32_stack_frame_unwinder.cc",
1211 "profiler/win32_stack_frame_unwinder.h", 1219 "profiler/win32_stack_frame_unwinder.h",
1212 ] 1220 ]
1213 1221
(...skipping 1269 matching lines...) Expand 10 before | Expand all | Expand 10 after
2483 } 2491 }
2484 2492
2485 fuzzer_test("base_json_correctness_fuzzer") { 2493 fuzzer_test("base_json_correctness_fuzzer") {
2486 sources = [ 2494 sources = [
2487 "json/correctness_fuzzer.cc", 2495 "json/correctness_fuzzer.cc",
2488 ] 2496 ]
2489 deps = [ 2497 deps = [
2490 ":base", 2498 ":base",
2491 ] 2499 ]
2492 } 2500 }
OLDNEW
« no previous file with comments | « no previous file | base/synchronization/spin_lock.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698