Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Issue 2484413002: Enhance chrome.app.window API with title property

Created:
4 years, 1 month ago by Andra Paraschiv
Modified:
3 years, 11 months ago
CC:
chromium-reviews, kalyank, sadrul, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enhance chrome.app.window API with title property Enhance chrome.app.window API with the possibility of creating a window shown in shelf that has its own title/tooltip. Added a new property, title, to CreateWindowOptions. Based on https://codereview.chromium.org/2341643002 Co-Authored-By: Valentin Ilie <valentin.ilie@intel.com>; BUG=610299 TEST = https://codereview.chromium.org/2297633002

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -33 lines) Patch
M chrome/browser/ui/ash/launcher/app_shortcut_launcher_item_controller.h View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/launcher/app_shortcut_launcher_item_controller.cc View 1 2 4 chunks +15 lines, -4 lines 0 comments Download
M chrome/browser/ui/ash/launcher/app_window_launcher_item_controller.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/ash/launcher/app_window_launcher_item_controller.cc View 1 2 3 chunks +8 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/launcher/arc_app_deferred_launcher_item_controller.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/arc_app_window_launcher_item_controller.cc View 1 2 1 chunk +5 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/arc_playstore_shortcut_launcher_item_controller.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h View 1 3 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc View 1 2 8 chunks +17 lines, -8 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_browsertest.cc View 1 8 chunks +10 lines, -9 lines 1 comment Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc View 1 2 5 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_mus.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_mus.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/launcher/extension_app_window_launcher_controller.cc View 1 2 chunks +9 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/extension_app_window_launcher_item_controller.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/ash/launcher/extension_app_window_launcher_item_controller.cc View 1 1 chunk +6 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/launcher_item_controller.h View 1 2 3 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/launcher/launcher_item_controller.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M extensions/browser/api/app_window/app_window_api.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M extensions/browser/app_window/app_window.h View 3 chunks +8 lines, -0 lines 0 comments Download
M extensions/browser/app_window/app_window.cc View 1 2 2 chunks +6 lines, -1 line 0 comments Download
M extensions/common/api/app_window.idl View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
stevenjb
This needs it's own tracking issue. Has this gone through the steps described in http://dev.chromium.org/developers/design-documents/extensions/proposed-changes/apis-under-development ...
4 years, 1 month ago (2016-11-09 18:42:15 UTC) #4
Andra Paraschiv
Thank you for feedback and for the explanation. Ok, we should discuss this before moving ...
4 years, 1 month ago (2016-11-10 07:53:43 UTC) #5
Mr4D (OOO till 08-26)
3 years, 11 months ago (2017-01-06 16:37:57 UTC) #6
https://codereview.chromium.org/2484413002/diff/40001/chrome/browser/ui/ash/l...
File
chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_browsertest.cc
(right):

https://codereview.chromium.org/2484413002/diff/40001/chrome/browser/ui/ash/l...
chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_browsertest.cc:315:

I think it would be a good idea to add a test which also checks that the title
gets properly returned (so - all of the cases: Title, default title or even "").

Powered by Google App Engine
This is Rietveld 408576698