Enhance chrome.app.window API with title property

chrome/browser/ui/ash/launcher/launcher_item_controller.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_ASH_LAUNCHER_LAUNCHER_ITEM_CONTROLLER_H_
 #define CHROME_BROWSER_UI_ASH_LAUNCHER_LAUNCHER_ITEM_CONTROLLER_H_
 
 #include <string>
 
 #include "ash/common/shelf/shelf_item_delegate.h"
@@ skipping 25 matching lines @@
   enum Type {
     TYPE_APP,
     TYPE_APP_PANEL,
     TYPE_SHORTCUT,
     TYPE_WINDOWED_APP
   };
 
   LauncherItemController(Type type,
                          const std::string& app_id,
                          const std::string& launch_id,
+                         const std::string& title,

[stevenjb, 2016/11/09 18:42:15]

Adding 'launch_id' to the constructor made sense because it is part of the
unique identifier for the item.

Adding 'title' when it is mostly unused just creates a lot of churn. Instead we
should add a set_title() method. (But also see my other comments).

[Andra Paraschiv, 2016/11/10 07:53:43]

Ok, thank you for this. I will try to modify this to be simpler and without many
code changes.

                          ChromeLauncherController* launcher_controller);
   ~LauncherItemController() override;
 
   Type type() const { return type_; }
   ash::ShelfID shelf_id() const { return shelf_id_; }
   void set_shelf_id(ash::ShelfID id) { shelf_id_ = id; }
   const std::string& app_id() const { return app_id_; }
   const std::string& launch_id() const { return launch_id_; }
+  const std::string& title() const { return title_; }
   ChromeLauncherController* launcher_controller() const {
     return launcher_controller_;
   }
 
   // Lock this item to the launcher without being pinned (windowed v1 apps).
   void lock() { locked_++; }
   void unlock() {
     DCHECK(locked_);
     locked_--;
   }
@@ skipping 25 matching lines @@
   ash::ShelfItemType GetShelfItemType() const;
 
  private:
   const Type type_;
   // App id will be empty if there is no app associated with the window.
   const std::string app_id_;
   // An id that can be passed to an app when launched in order to support
   // multiple shelf items per app. This id is used together with the app_id to
   // uniquely identify each shelf item that has the same app_id.
   const std::string launch_id_;
+  // Title of the window that has its own icon in the shelf.
+  const std::string title_;
   // A unique id assigned by the shelf model for the shelf item.
   ash::ShelfID shelf_id_;
   ChromeLauncherController* launcher_controller_;
 
   // The lock counter which tells the launcher if the item can be removed from
   // the launcher (0) or not (>0). It is being used for windowed V1
   // applications.
   int locked_;
 
   // Set to true if the launcher item image has been set by the controller.
   bool image_set_by_controller_;
 
   DISALLOW_COPY_AND_ASSIGN(LauncherItemController);
 };
 
 #endif  // CHROME_BROWSER_UI_ASH_LAUNCHER_LAUNCHER_ITEM_CONTROLLER_H_