Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(798)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2297633002: Add chrome.app.window API tests for items shown in shelf

Created:
4 years, 3 months ago by Andra Paraschiv
Modified:
4 years ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add chrome.app.window API tests for items shown in shelf Add unit tests for items that have their own icon in shelf. Check if the chrome.app.window API parameters e.g. icon, showInShelf are properly set. Based on https://codereview.chromium.org/1914993002 Based on https://codereview.chromium.org/2209053004 Based on https://codereview.chromium.org/2290603002 Based on https://codereview.chromium.org/2341643002 Based on https://codereview.chromium.org/2484413002 Based on https://codereview.chromium.org/2523053004 Based on https://codereview.chromium.org/2530903002 Co-Authored-By: Valentin Ilie <valentin.ilie@intel.com>; BUG=610299 TEST=AppWindowBrowserTest, LauncherPlatformAppBrowserTest

Patch Set 1 #

Patch Set 2 : Window Icon Test #

Patch Set 3 : Window Icon Pinning Tests #

Patch Set 4 : Rebase #

Patch Set 5 : Shelf Windows Pinning Tests #

Patch Set 6 : Rebase #

Patch Set 7 : Pin and Restore Unit Test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+344 lines, -0 lines) Patch
M chrome/browser/apps/app_browsertest_util.h View 1 2 3 4 5 6 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/apps/app_browsertest_util.cc View 1 2 3 4 5 6 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_browsertest.cc View 1 2 3 4 5 6 5 chunks +266 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/platform_apps/app_window/generic/icon_128.png View Binary file 0 comments Download
M extensions/browser/app_window/app_window_browsertest.cc View 1 2 chunks +70 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
stevenjb
It looks like there is an image test resource and some includes that are not ...
4 years, 3 months ago (2016-08-30 16:15:21 UTC) #3
stevenjb
4 years, 3 months ago (2016-08-30 16:15:26 UTC) #4
Andra Paraschiv
On 2016/08/30 16:15:21, stevenjb wrote: > It looks like there is an image test resource ...
4 years, 3 months ago (2016-08-31 06:36:40 UTC) #5
stevenjb
4 years, 3 months ago (2016-09-01 16:02:19 UTC) #7 
+jamescook@ (note, this CL isn't ready yet)

Powered by Google App Engine
This is Rietveld 408576698