[LayoutNG] Split apart storage for AvailableSize and PercentageSize.

[LayoutNG] Split apart storage for AvailableSize and PercentageSize.

Additionally removes ContainerSize.

We've got lots of small corner cases which we aren't handling correctly
in ng_length_utils (i.e. orthoganal writing mode %-resolution). But
will fix these in follow-up patch.

BUG=635619
Committed: https://crrev.com/0f0f0b8544ca09a87a7c855210ca8fc1128b5a56
Cr-Commit-Position: refs/heads/master@{#430434}

[ikilpatrick, 2016-11-07 01:24:40]

The CQ bit was checked by ikilpatrick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-07 01:24:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ikilpatrick, 2016-11-07 01:26:03]

ikilpatrick@chromium.org changed reviewers:
+ cbiesinger@chromium.org, eae@chromium.org

[ikilpatrick, 2016-11-07 01:26:04]

https://codereview.chromium.org/2483683003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/ng/ng_box.cc (right):

https://codereview.chromium.org/2483683003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/ng/ng_box.cc:131:
builder.SetPercentageSize(NGLogicalSize(LayoutUnit(), LayoutUnit()));
? percentages should resolve to 0 here?

[eae, 2016-11-07 01:29:44]

LGTM w/optional suggestion

https://codereview.chromium.org/2483683003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h (right):

https://codereview.chromium.org/2483683003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h:69: NGLogicalSize
PercentageSize() const;
PercentageSize makes it sound like a size expressed in percentage points.
SizeForPercentageResolution or PercentageResolutionSize might be more
descriptive?

[ikilpatrick, 2016-11-07 02:00:09]

The CQ bit was checked by ikilpatrick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-07 02:00:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ikilpatrick, 2016-11-07 02:00:31]

https://codereview.chromium.org/2483683003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h (right):

https://codereview.chromium.org/2483683003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h:69: NGLogicalSize
PercentageSize() const;
On 2016/11/07 01:29:44, eae wrote:
> PercentageSize makes it sound like a size expressed in percentage points.
> SizeForPercentageResolution or PercentageResolutionSize might be more
> descriptive?

sgtm done.

[commit-bot: I haz the power, 2016-11-07 03:32:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-07 03:32:43]

Dry run: This issue passed the CQ dry run.

[cbiesinger, 2016-11-07 20:57:43]

lgtm

https://codereview.chromium.org/2483683003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/ng/ng_box.cc (right):

https://codereview.chromium.org/2483683003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/ng/ng_box.cc:131:
builder.SetPercentageSize(NGLogicalSize(LayoutUnit(), LayoutUnit()));
On 2016/11/07 01:26:04, ikilpatrick wrote:
> ? percentages should resolve to 0 here?

Yes, they should.

[cbiesinger, 2016-11-07 20:58:27]

> (i.e. orthoganal writing mode %-resolution).

BTW, how do we mishandle that? I thought that worked correctly due to the
writing mode change we do in NGBox::Layout.

[ikilpatrick, 2016-11-07 22:49:45]

The CQ bit was checked by ikilpatrick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-07 22:50:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ikilpatrick, 2016-11-07 22:51:04]

On 2016/11/07 20:58:27, cbiesinger wrote:
> > (i.e. orthoganal writing mode %-resolution).
> 
> BTW, how do we mishandle that? I thought that worked correctly due to the
> writing mode change we do in NGBox::Layout.

I think we currently handle indefinite sizes incorrectly (we crash?) for inline;
i had a fix but left it out of this patch as it was getting too unwieldy. :)

[cbiesinger, 2016-11-07 23:14:26]

On 2016/11/07 22:51:04, ikilpatrick wrote:
> On 2016/11/07 20:58:27, cbiesinger wrote:
> > > (i.e. orthoganal writing mode %-resolution).
> > 
> > BTW, how do we mishandle that? I thought that worked correctly due to the
> > writing mode change we do in NGBox::Layout.
> 
> I think we currently handle indefinite sizes incorrectly (we crash?) for
inline;
> i had a fix but left it out of this patch as it was getting too unwieldy. :)

Ah yes, that one... that was on my todo list as well, glad you have a fix :)

[ikilpatrick, 2016-11-07 23:35:17]

The CQ bit was unchecked by ikilpatrick@chromium.org

[ikilpatrick, 2016-11-07 23:35:27]

The CQ bit was checked by ikilpatrick@chromium.org

[ikilpatrick, 2016-11-07 23:35:28]

The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org,
cbiesinger@chromium.org
Link to the patchset: https://codereview.chromium.org/2483683003/#ps40001
(title: "rebase.")

[commit-bot: I haz the power, 2016-11-07 23:36:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[atotic, 2016-11-08 00:01:28]

On 2016/11/07 at 23:14:26, cbiesinger wrote:
> On 2016/11/07 22:51:04, ikilpatrick wrote:
> > On 2016/11/07 20:58:27, cbiesinger wrote:
> > > > (i.e. orthoganal writing mode %-resolution).
> > > 
> > > BTW, how do we mishandle that? I thought that worked correctly due to the
> > > writing mode change we do in NGBox::Layout.
> > 
> > I think we currently handle indefinite sizes incorrectly (we crash?) for
inline;
> > i had a fix but left it out of this patch as it was getting too unwieldy. :)
> 
> Ah yes, that one... that was on my todo list as well, glad you have a fix :)

Me too, would love to know how you are fixing it, because I get bitten by it in
abspos when vertical-rl.

[commit-bot: I haz the power, 2016-11-08 00:12:11]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-08 00:33:12]

Description was changed from

==========
[LayoutNG] Split apart storage for AvailableSize and PercentageSize.

Additionally removes ContainerSize.

We've got lots of small corner cases which we aren't handling correctly
in ng_length_utils (i.e. orthoganal writing mode %-resolution). But
will fix these in follow-up patch.

BUG=635619
==========

to

==========
[LayoutNG] Split apart storage for AvailableSize and PercentageSize.

Additionally removes ContainerSize.

We've got lots of small corner cases which we aren't handling correctly
in ng_length_utils (i.e. orthoganal writing mode %-resolution). But
will fix these in follow-up patch.

BUG=635619

Committed: https://crrev.com/0f0f0b8544ca09a87a7c855210ca8fc1128b5a56
Cr-Commit-Position: refs/heads/master@{#430434}
==========

[commit-bot: I haz the power, 2016-11-08 00:33:13]

Patchset 3 (id:??) landed as
https://crrev.com/0f0f0b8544ca09a87a7c855210ca8fc1128b5a56
Cr-Commit-Position: refs/heads/master@{#430434}