third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.h - Issue 2483683003: [LayoutNG] Split apart storage for AvailableSize and PercentageSize.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.h

Issue 2483683003: [LayoutNG] Split apart storage for AvailableSize and PercentageSize. (Closed)

Patch Set: rebase. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc ('k') | third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.h

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.h b/third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.h

index db9a641c820f6dafe1d5f46feb98db8178254151..3f37ac8084116fff36dfa3894c9ae1bf3f284902 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.h

+++ b/third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.h

@@ -15,7 +15,10 @@ class CORE_EXPORT NGConstraintSpaceBuilder final

public:

NGConstraintSpaceBuilder(NGWritingMode writing_mode);

- NGConstraintSpaceBuilder& SetContainerSize(NGLogicalSize container_size);

+ NGConstraintSpaceBuilder& SetAvailableSize(NGLogicalSize available_size);

+ NGConstraintSpaceBuilder& SetPercentageResolutionSize(

+ NGLogicalSize percentage_resolution_size);

NGConstraintSpaceBuilder& SetIsFixedSizeInline(bool is_fixed_size_inline);

NGConstraintSpaceBuilder& SetIsFixedSizeBlock(bool is_fixed_size_block);

@@ -39,7 +42,8 @@ class CORE_EXPORT NGConstraintSpaceBuilder final

DEFINE_INLINE_TRACE() {}

private:

- NGLogicalSize container_size_;

+ NGLogicalSize available_size_;

+ NGLogicalSize percentage_resolution_size_;

// const bit fields.

const unsigned writing_mode_ : 2;