third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc - Issue 2483683003: [LayoutNG] Split apart storage for AvailableSize and PercentageSize.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc

Issue 2483683003: [LayoutNG] Split apart storage for AvailableSize and PercentageSize. (Closed)

Patch Set: rebase. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.cc ('k') | third_party/WebKit/Source/core/layout/ng/ng_layout_algorithm.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc b/third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc

index 9eb8f08400e011685eb15ec3db1d582615c147e2..367a8d594c9e90dad3bfc3f94b16b51fa7df4285 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc

+++ b/third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc

@@ -19,7 +19,7 @@ NGConstraintSpace* ConstructConstraintSpace(NGWritingMode writing_mode,

return new NGConstraintSpace(

writing_mode, direction,

new NGPhysicalConstraintSpace(

- size, /* fixed_width */ true, /* fixed_height */ false,

+ size, size, /* fixed_width */ true, /* fixed_height */ false,

/* width_direction_triggers_scrollbar */ true,

/* height_direction_triggers_scrollbar */ false, FragmentNone,

FragmentColumn, /* is_new_fc */ false));

@@ -27,6 +27,7 @@ NGConstraintSpace* ConstructConstraintSpace(NGWritingMode writing_mode,

TEST(NGConstraintSpaceTest, WritingMode) {

NGPhysicalConstraintSpace* phy_space = new NGPhysicalConstraintSpace(

+ NGPhysicalSize(LayoutUnit(200), LayoutUnit(100)),

NGPhysicalSize(LayoutUnit(200), LayoutUnit(100)), /* fixed_width */ true,

/* fixed_height */ false, /* width_direction_triggers_scrollbar */ true,

/* height_direction_triggers_scrollbar */ false, FragmentNone,

@@ -38,11 +39,11 @@ TEST(NGConstraintSpaceTest, WritingMode) {

NGConstraintSpace* vert_space =

new NGConstraintSpace(VerticalRightLeft, LeftToRight, phy_space);

- EXPECT_EQ(LayoutUnit(200), horz_space->ContainerSize().inline_size);

- EXPECT_EQ(LayoutUnit(200), vert_space->ContainerSize().block_size);

+ EXPECT_EQ(LayoutUnit(200), horz_space->AvailableSize().inline_size);

+ EXPECT_EQ(LayoutUnit(200), vert_space->AvailableSize().block_size);

- EXPECT_EQ(LayoutUnit(100), horz_space->ContainerSize().block_size);

- EXPECT_EQ(LayoutUnit(100), vert_space->ContainerSize().inline_size);

+ EXPECT_EQ(LayoutUnit(100), horz_space->AvailableSize().block_size);

+ EXPECT_EQ(LayoutUnit(100), vert_space->AvailableSize().inline_size);

EXPECT_TRUE(horz_space->InlineTriggersScrollbar());

EXPECT_TRUE(vert_space->BlockTriggersScrollbar());