third_party/WebKit/Source/core/layout/line/LineBreaker.cpp - Issue 2483023002: Let positionNewFloats() take a logicalTop parameter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/line/LineBreaker.cpp

Issue 2483023002: Let positionNewFloats() take a logicalTop parameter. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/line/LineBreaker.cpp

diff --git a/third_party/WebKit/Source/core/layout/line/LineBreaker.cpp b/third_party/WebKit/Source/core/layout/line/LineBreaker.cpp

index 4d8dae123f60afacfb6cf59cb135fd0a8b93a774..d7fb2789d00a4f4a40a0ca67e6fdf96070c27989 100644

--- a/third_party/WebKit/Source/core/layout/line/LineBreaker.cpp

+++ b/third_party/WebKit/Source/core/layout/line/LineBreaker.cpp

@@ -43,7 +43,7 @@ void LineBreaker::skipLeadingWhitespace(InlineBidiResolver& resolver,

}

} else if (lineLayoutItem.isFloating()) {

m_block.insertFloatingObject(LineLayoutBox(lineLayoutItem));

- m_block.positionNewFloats(&width);

+ m_block.positionNewFloats(m_block.logicalHeight(), &width);

}

resolver.position().increment(&resolver);

}