third_party/WebKit/Source/core/layout/line/LineWidth.cpp - Issue 2483023002: Let positionNewFloats() take a logicalTop parameter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/line/LineWidth.cpp

Issue 2483023002: Let positionNewFloats() take a logicalTop parameter. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/line/LineWidth.cpp

diff --git a/third_party/WebKit/Source/core/layout/line/LineWidth.cpp b/third_party/WebKit/Source/core/layout/line/LineWidth.cpp

index 762ffe78d1766478ed3fa23ad2e1a8be9f20fee3..badca245264ccfc5258b8eb3950c47dface5a1ea 100644

--- a/third_party/WebKit/Source/core/layout/line/LineWidth.cpp

+++ b/third_party/WebKit/Source/core/layout/line/LineWidth.cpp

@@ -191,7 +191,7 @@ void LineWidth::wrapNextToShapeOutside(bool isFirstLine) {

void LineWidth::fitBelowFloats(bool isFirstLine) {

ASSERT(!m_committedWidth);

ASSERT(!fitsOnLine());

- m_block.positionNewFloats(this);

+ m_block.positionNewFloats(m_block.logicalHeight(), this);

LayoutUnit floatLogicalBottom;

LayoutUnit lastFloatLogicalBottom = m_block.logicalHeight();

« no previous file with comments | « third_party/WebKit/Source/core/layout/line/LineBreaker.cpp ('k') | no next file » | no next file with comments »