third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h - Issue 2483023002: Let positionNewFloats() take a logicalTop parameter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h

Issue 2483023002: Let positionNewFloats() take a logicalTop parameter. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/api/LineLayoutBlockFlow.h ('k') | third_party/WebKit/Source/core/layout/line/LineBreaker.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h

diff --git a/third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h b/third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h

index 9442a3172f7acec8a13418db517212650cff2954..03bf794d0016a12d7ea4ebd1cd38171fa6a3e9c1 100644

--- a/third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h

+++ b/third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h

@@ -496,7 +496,7 @@ inline void BreakingContext::handleFloat() {

m_width.fitsOnLine(

m_block.logicalWidthForFloat(*floatingObject).toFloat(),

ExcludeWhitespace)) {

- m_block.positionNewFloats(&m_width);

+ m_block.positionNewFloats(m_block.logicalHeight(), &m_width);

if (m_lineBreak.getLineLayoutItem() == m_current.getLineLayoutItem()) {

ASSERT(!m_lineBreak.offset());

m_lineBreak.increment();