Implement tex{Sub}Image3D taking sub-rectangles of HTMLImageElements.

Implement tex{Sub}Image3D taking sub-rectangles of HTMLImageElements.

Tested with new tests in
https://github.com/KhronosGroup/WebGL/pull/2132 .

Also includes the following needed WebGL conformance roll:

Roll WebGL 7516ab7..bc2b06d

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/7516ab7..bc2b06d

BUG=639145
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/2658d763101ffadcdff084dbcb239643192bf3b4
Cr-Commit-Position: refs/heads/master@{#430762}

[Ken Russell (switch to Gerrit), 2016-11-08 06:22:37]

Description was changed from

==========
Implement tex{Sub}Image3D taking sub-rectangles of HTMLImageElements.

Tested with new tests in
https://github.com/KhronosGroup/WebGL/pull/2132 .

BUG=639145
==========

to

==========
Implement tex{Sub}Image3D taking sub-rectangles of HTMLImageElements.

Tested with new tests in
https://github.com/KhronosGroup/WebGL/pull/2132 .

BUG=639145
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Ken Russell (switch to Gerrit), 2016-11-08 06:24:40]

kbr@chromium.org changed reviewers:
+ kainino@chromium.org, zmo@chromium.org

[Ken Russell (switch to Gerrit), 2016-11-08 06:24:41]

Mo, Kai: please review. Thanks.

[Ken Russell (switch to Gerrit), 2016-11-08 06:29:02]

The CQ bit was checked by kbr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-08 06:29:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 07:47:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-08 07:47:02]

Dry run: Try jobs failed on following builders:
  linux_optional_gpu_tests_rel on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_optional_...)

[Zhenyao Mo, 2016-11-08 18:10:31]

https://codereview.chromium.org/2482793005/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
(right):

https://codereview.chromium.org/2482793005/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp:4406: "Not
enough data supplied to upload to a 3D texture with depth > 1");
missing a return here.

[Kai Ninomiya, 2016-11-08 21:43:35]

Looks good aside from zmo's comment

[Ken Russell (switch to Gerrit), 2016-11-08 21:46:10]

Description was changed from

==========
Implement tex{Sub}Image3D taking sub-rectangles of HTMLImageElements.

Tested with new tests in
https://github.com/KhronosGroup/WebGL/pull/2132 .

BUG=639145
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Implement tex{Sub}Image3D taking sub-rectangles of HTMLImageElements.

Tested with new tests in
https://github.com/KhronosGroup/WebGL/pull/2132 .

Also includes the following needed WebGL conformance roll:

Roll WebGL 7516ab7..bc2b06d

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/7516ab...

BUG=639145
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Ken Russell (switch to Gerrit), 2016-11-08 21:46:32]

PTAL. Now includes needed WebGL conformance roll.

https://codereview.chromium.org/2482793005/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
(right):

https://codereview.chromium.org/2482793005/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp:4406: "Not
enough data supplied to upload to a 3D texture with depth > 1");
On 2016/11/08 18:10:31, Zhenyao Mo wrote:
> missing a return here.

Fixed.

[Ken Russell (switch to Gerrit), 2016-11-08 21:46:37]

The CQ bit was checked by kbr@chromium.org to run a CQ dry run

[Zhenyao Mo, 2016-11-08 21:47:18]

On 2016/11/08 21:46:32, Ken Russell wrote:
> PTAL. Now includes needed WebGL conformance roll.
> 
>
https://codereview.chromium.org/2482793005/diff/1/third_party/WebKit/Source/m...
> File third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
> (right):
> 
>
https://codereview.chromium.org/2482793005/diff/1/third_party/WebKit/Source/m...
> third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp:4406:
"Not
> enough data supplied to upload to a 3D texture with depth > 1");
> On 2016/11/08 18:10:31, Zhenyao Mo wrote:
> > missing a return here.
> 
> Fixed.

lgtm

[commit-bot: I haz the power, 2016-11-08 21:47:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Russell (switch to Gerrit), 2016-11-08 21:47:35]

The CQ bit was unchecked by kbr@chromium.org

[Ken Russell (switch to Gerrit), 2016-11-08 21:47:42]

The CQ bit was checked by kbr@chromium.org

[Kai Ninomiya, 2016-11-08 21:48:05]

lgtm

[commit-bot: I haz the power, 2016-11-08 21:48:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 23:39:08]

Description was changed from

==========
Implement tex{Sub}Image3D taking sub-rectangles of HTMLImageElements.

Tested with new tests in
https://github.com/KhronosGroup/WebGL/pull/2132 .

Also includes the following needed WebGL conformance roll:

Roll WebGL 7516ab7..bc2b06d

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/7516ab...

BUG=639145
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Implement tex{Sub}Image3D taking sub-rectangles of HTMLImageElements.

Tested with new tests in
https://github.com/KhronosGroup/WebGL/pull/2132 .

Also includes the following needed WebGL conformance roll:

Roll WebGL 7516ab7..bc2b06d

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/7516ab...

BUG=639145
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-11-08 23:39:09]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-08 23:41:56]

Description was changed from

==========
Implement tex{Sub}Image3D taking sub-rectangles of HTMLImageElements.

Tested with new tests in
https://github.com/KhronosGroup/WebGL/pull/2132 .

Also includes the following needed WebGL conformance roll:

Roll WebGL 7516ab7..bc2b06d

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/7516ab...

BUG=639145
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Implement tex{Sub}Image3D taking sub-rectangles of HTMLImageElements.

Tested with new tests in
https://github.com/KhronosGroup/WebGL/pull/2132 .

Also includes the following needed WebGL conformance roll:

Roll WebGL 7516ab7..bc2b06d

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/7516ab...

BUG=639145
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/2658d763101ffadcdff084dbcb239643192bf3b4
Cr-Commit-Position: refs/heads/master@{#430762}
==========

[commit-bot: I haz the power, 2016-11-08 23:41:57]

Patchset 2 (id:??) landed as
https://crrev.com/2658d763101ffadcdff084dbcb239643192bf3b4
Cr-Commit-Position: refs/heads/master@{#430762}