third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h - Issue 2482793005: Implement tex{Sub}Image3D taking sub-rectangles of HTMLImageElements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h

Issue 2482793005: Implement tex{Sub}Image3D taking sub-rectangles of HTMLImageElements. (Closed)

Patch Set: Early out in case of error. Roll WebGL conformance tests too. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.idl ('k') | third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h

diff --git a/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h b/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h

index cd2bb15be5dd0b5e115f89248a3034ace95706b3..1003cea199f10f9117d95b131613bac886c49974 100644

--- a/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h

+++ b/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h

@@ -1019,7 +1019,9 @@ class MODULES_EXPORT WebGLRenderingContextBase : public CanvasRenderingContext,

WebGLImageConversion::ImageHtmlDomSource,

bool flipY,

bool premultiplyAlpha,

- const IntRect&);

+ const IntRect&,

+ GLsizei depth,

+ GLint unpackImageHeight);

// Copy from the source directly to the texture via the gpu, without a

// read-back to system memory. Souce could be canvas or imageBitmap.

@@ -1490,6 +1492,8 @@ class MODULES_EXPORT WebGLRenderingContextBase : public CanvasRenderingContext,

GLint,

HTMLImageElement*,

const IntRect&,

+ GLsizei,

+ GLint,

ExceptionState&);

void texImageHelperHTMLCanvasElement(TexImageFunctionID,

GLenum,