Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Side by Side Diff: third_party/WebKit/Source/modules/compositorworker/WindowAnimationWorklet.cpp

Issue 2482393002: [worklets] Fixes leak document leak for AnimationWorklet. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/modules/compositorworker/WindowAnimationWorklet.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "modules/compositorworker/WindowAnimationWorklet.h" 5 #include "modules/compositorworker/WindowAnimationWorklet.h"
6 6
7 #include "core/frame/LocalDOMWindow.h" 7 #include "core/frame/LocalDOMWindow.h"
8 #include "core/frame/LocalFrame.h" 8 #include "core/frame/LocalFrame.h"
9 #include "modules/compositorworker/AnimationWorklet.h" 9 #include "modules/compositorworker/AnimationWorklet.h"
10 10
(...skipping 21 matching lines...) Expand all
32 Worklet* WindowAnimationWorklet::animationWorklet(DOMWindow& window) { 32 Worklet* WindowAnimationWorklet::animationWorklet(DOMWindow& window) {
33 return from(toLocalDOMWindow(window)).animationWorklet(); 33 return from(toLocalDOMWindow(window)).animationWorklet();
34 } 34 }
35 35
36 AnimationWorklet* WindowAnimationWorklet::animationWorklet() { 36 AnimationWorklet* WindowAnimationWorklet::animationWorklet() {
37 if (!m_animationWorklet && frame()) 37 if (!m_animationWorklet && frame())
38 m_animationWorklet = AnimationWorklet::create(frame()); 38 m_animationWorklet = AnimationWorklet::create(frame());
39 return m_animationWorklet.get(); 39 return m_animationWorklet.get();
40 } 40 }
41 41
42 void WindowAnimationWorklet::frameDestroyed() {
43 m_animationWorklet.clear();
44 DOMWindowProperty::frameDestroyed();
45 }
46
42 DEFINE_TRACE(WindowAnimationWorklet) { 47 DEFINE_TRACE(WindowAnimationWorklet) {
43 visitor->trace(m_animationWorklet); 48 visitor->trace(m_animationWorklet);
44 Supplement<LocalDOMWindow>::trace(visitor); 49 Supplement<LocalDOMWindow>::trace(visitor);
45 DOMWindowProperty::trace(visitor); 50 DOMWindowProperty::trace(visitor);
46 } 51 }
47 52
48 } // namespace blink 53 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/modules/compositorworker/WindowAnimationWorklet.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698