[WIP] make GURL::path() return a StringPiece

chrome/browser/extensions/api/extension_action/browser_action_apitest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stdint.h>
 
 #include "base/files/file_path.h"
 #include "base/files/file_util.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/macros.h"
@@ skipping 454 matching lines @@
   // current tab's setting should have changed, but the default setting
   // should not have changed.
   ASSERT_TRUE(browser_action->HasPopup(tab_id))
       << "Clicking on the browser action should have caused a popup to "
       << "be added.";
   ASSERT_FALSE(browser_action->HasPopup(ExtensionAction::kDefaultTabId))
       << "Clicking on the browser action should not have set a default "
       << "popup.";
 
   ASSERT_STREQ("/a_popup.html",
-               browser_action->GetPopupUrl(tab_id).path().c_str());
+               browser_action->GetPopupUrl(tab_id).path().as_string().c_str());
 
   // Now change the popup from a_popup.html to another_popup.html by loading
   // a page which removes the popup using chrome.browserAction.setPopup().
   {
     ResultCatcher catcher;
     ui_test_utils::NavigateToURL(
         browser(),
         GURL(extension->GetResourceURL("change_popup.html")));
     ASSERT_TRUE(catcher.GetNextResult());
   }
 
   // The call to setPopup in change_popup.html did not use a tab id,
   // so the default setting should have changed as well as the current tab.
   ASSERT_TRUE(browser_action->HasPopup(tab_id));
   ASSERT_TRUE(browser_action->HasPopup(ExtensionAction::kDefaultTabId));
   ASSERT_STREQ("/another_popup.html",
-               browser_action->GetPopupUrl(tab_id).path().c_str());
+               browser_action->GetPopupUrl(tab_id).path().as_string().c_str());
 }
 
 // Test that calling chrome.browserAction.setPopup() can remove a popup.
 IN_PROC_BROWSER_TEST_F(BrowserActionApiTest, BrowserActionRemovePopup) {
   // Load the extension, which has a browser action with a default popup.
   ASSERT_TRUE(RunExtensionTest("browser_action/remove_popup")) << message_;
   const Extension* extension = GetSingleLoadedExtension();
   ASSERT_TRUE(extension) << message_;
 
   int tab_id = ExtensionTabUtil::GetTabId(
@@ skipping 537 matching lines @@
   // The test verification below is applicable only to scenarios where the
   // download shelf is supported - on ChromeOS, instead of the download shelf,
   // there is a download notification in the right-bottom corner of the screen.
 #if !defined(OS_CHROMEOS)
   EXPECT_TRUE(browser()->window()->IsDownloadShelfVisible());
 #endif
 }
 
 }  // namespace
 }  // namespace extensions