Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2481413003: skpbench: simplify adb and reduce number of invocations (Closed)

Created:
4 years, 1 month ago by csmartdalton
Modified:
4 years, 1 month ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

skpbench: simplify adb and reduce number of invocations This change reduces a bit of startup overhead by condensing more bash into fewer invocations of 'adb shell'. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2481413003 Committed: https://skia.googlesource.com/skia/+/e4fd0780ec279845ea98e18899f03d939b01db16

Patch Set 1 #

Patch Set 2 : skpbench: simplify adb and reduce number of invocations #

Patch Set 3 : skpbench: simplify adb and reduce number of invocations #

Patch Set 4 : skpbench: simplify adb and reduce number of invocations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -108 lines) Patch
M tools/skpbench/_adb.py View 1 1 chunk +28 lines, -18 lines 0 comments Download
M tools/skpbench/_adb_path.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/skpbench/_hardware_android.py View 2 chunks +45 lines, -60 lines 0 comments Download
M tools/skpbench/_hardware_nexus_6p.py View 4 chunks +5 lines, -5 lines 0 comments Download
M tools/skpbench/_hardware_pixel_c.py View 1 2 3 2 chunks +20 lines, -18 lines 0 comments Download
M tools/skpbench/skpbench.py View 1 3 chunks +6 lines, -5 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 19 (11 generated)
csmartdalton
4 years, 1 month ago (2016-11-08 22:10:22 UTC) #4
bsalomon
lgtm
4 years, 1 month ago (2016-11-09 15:06:30 UTC) #5
csmartdalton
Added a simple change to reduce a couple more in pixel c.
4 years, 1 month ago (2016-11-09 15:44:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2481413003/40001
4 years, 1 month ago (2016-11-09 15:45:03 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on master.client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/15961)
4 years, 1 month ago (2016-11-09 15:46:33 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2481413003/50001
4 years, 1 month ago (2016-11-09 15:54:13 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2481413003/50001
4 years, 1 month ago (2016-11-09 15:54:33 UTC) #17
commit-bot: I haz the power
4 years, 1 month ago (2016-11-09 16:41:26 UTC) #19
Message was sent while issue was closed.
Committed patchset #4 (id:50001) as
https://skia.googlesource.com/skia/+/e4fd0780ec279845ea98e18899f03d939b01db16

Powered by Google App Engine
This is Rietveld 408576698