Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2491633002: skpbench: use 3 cores instead of 4 on Pixel C (Closed)

Created:
4 years, 1 month ago by csmartdalton
Modified:
4 years, 1 month ago
Reviewers:
kjlubick, bsalomon
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

skpbench: use 3 cores instead of 4 on Pixel C Hopefully with less cores running we will produce less heat. 3 cores should be enough to run Ganesh, the graphics driver, and the OS. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2491633002 Committed: https://skia.googlesource.com/skia/+/b87642e0186cfd43a196627234743b0f81ffc65f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -7 lines) Patch
M tools/skpbench/_hardware_pixel_c.py View 4 chunks +22 lines, -7 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (5 generated)
csmartdalton
4 years, 1 month ago (2016-11-09 19:14:50 UTC) #3
kjlubick
Can you add a comment to this CL on why it is a good idea ...
4 years, 1 month ago (2016-11-09 19:16:19 UTC) #4
csmartdalton
On 2016/11/09 19:16:19, kjlubick wrote: > Can you add a comment to this CL on ...
4 years, 1 month ago (2016-11-09 19:44:03 UTC) #6
kjlubick
lgtm
4 years, 1 month ago (2016-11-09 19:47:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2491633002/1
4 years, 1 month ago (2016-11-09 20:00:04 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-09 20:26:34 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/b87642e0186cfd43a196627234743b0f81ffc65f

Powered by Google App Engine
This is Rietveld 408576698