tools/skpbench/_adb_path.py - Issue 2481413003: skpbench: simplify adb and reduce number of invocations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/skpbench/_adb_path.py

Issue 2481413003: skpbench: simplify adb and reduce number of invocations (Closed)

Patch Set: skpbench: simplify adb and reduce number of invocations Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/skpbench/_adb_path.py

diff --git a/tools/skpbench/_adb_path.py b/tools/skpbench/_adb_path.py

index 72382bc1dc178af84c45f5186d25a7a21fcacd07..4d8bce44255675c7681ecc5d46e276a8e2949c98 100644

--- a/tools/skpbench/_adb_path.py

+++ b/tools/skpbench/_adb_path.py

@@ -22,11 +22,11 @@ def basename(pathname):

def find_skps(skps):

escapedskps = [re.sub(r'([^a-zA-Z0-9_/\.\*\?\[\!\]])', r'\\\1', x)

for x in skps]

- return __ADB.check_lines('''\

+ return __ADB.check('''\

for PATHNAME in %s; do

if [ -d "$PATHNAME" ]; then

find "$PATHNAME" -maxdepth 1 -name *.skp

else

echo "$PATHNAME"

- done''' % ' '.join(escapedskps))

+ done''' % ' '.join(escapedskps)).splitlines()

« no previous file with comments | « tools/skpbench/_adb.py ('k') | tools/skpbench/_hardware_android.py » ('j') | no next file with comments »