Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2481373003: Fix groupby-picker. (Closed)

Created:
4 years, 1 month ago by benjhayden
Modified:
4 years, 1 month ago
Reviewers:
eakuefner, nednguyen
CC:
catapult-reviews_chromium.org, tracing-review_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Fix groupby-picker. Currently, when localStorage[settingsKey] contains a grouping key that is not in possibleGroups, then |set currentGroupKeys| gets confused and tries to access a non-existent group element, causing a TypeError. This was broken by https://codereview.chromium.org/2458873002 https://bugs.chromium.org/p/chromium/issues/detail?id=661711 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/b6402725257bb09d6015a386c7ef5b61811b14f3

Patch Set 1 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M tracing/tracing/ui/base/grouping_table_groupby_picker.html View 1 chunk +2 lines, -0 lines 0 comments Download
M tracing/tracing/ui/base/grouping_table_groupby_picker_test.html View 3 chunks +12 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
benjhayden
The new test fails without the fix and passes with it. PTAL :-)
4 years, 1 month ago (2016-11-07 22:11:15 UTC) #6
eakuefner
Thanks Ben, and thanks especially for adding a test! lgtm
4 years, 1 month ago (2016-11-07 22:48:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2481373003/40001
4 years, 1 month ago (2016-11-08 00:27:34 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 00:57:44 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:40001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698