Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: tracing/tracing/ui/base/grouping_table_groupby_picker.html

Issue 2481373003: Fix groupby-picker. (Closed)
Patch Set: . Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tracing/tracing/ui/base/grouping_table_groupby_picker_test.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tracing/tracing/ui/base/grouping_table_groupby_picker.html
diff --git a/tracing/tracing/ui/base/grouping_table_groupby_picker.html b/tracing/tracing/ui/base/grouping_table_groupby_picker.html
index e929448df387371858b9b2b8d99f625ca003b1d7..e4422bf761679431750305fa9a7930f6a2d006d5 100644
--- a/tracing/tracing/ui/base/grouping_table_groupby_picker.html
+++ b/tracing/tracing/ui/base/grouping_table_groupby_picker.html
@@ -191,6 +191,8 @@ tr.exportTo('tr.ui.b', function() {
for (i = 0; i < newKeys.length; ++i) {
var group = possibleGroups.get(newKeys[i]);
if (group === undefined) {
+ newKeys.splice(i, 1);
+ --i;
continue;
}
groupEls[i].group = group;
« no previous file with comments | « no previous file | tracing/tracing/ui/base/grouping_table_groupby_picker_test.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698