Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Unified Diff: tracing/tracing/ui/base/grouping_table_groupby_picker_test.html

Issue 2481373003: Fix groupby-picker. (Closed)
Patch Set: . Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tracing/tracing/ui/base/grouping_table_groupby_picker.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tracing/tracing/ui/base/grouping_table_groupby_picker_test.html
diff --git a/tracing/tracing/ui/base/grouping_table_groupby_picker_test.html b/tracing/tracing/ui/base/grouping_table_groupby_picker_test.html
index 76eb12b210dddef5b6b93d8d96382918d6e6dae1..a7ac615a26cc1fd760b5f77fa79c1b8830c23428 100644
--- a/tracing/tracing/ui/base/grouping_table_groupby_picker_test.html
+++ b/tracing/tracing/ui/base/grouping_table_groupby_picker_test.html
@@ -12,9 +12,11 @@ found in the LICENSE file.
tr.b.unittest.testSuite(function() {
test('groupby-picker', function() {
+ var settingsKey = 'tr-ui-b-grouping-table-groupby-picker-test';
var picker = document.createElement(
'tr-ui-b-grouping-table-groupby-picker');
- picker.settingsKey = 'tr-ui-b-grouping-table-groupby-picker-test';
+ tr.b.Settings.set(settingsKey, []);
+ picker.settingsKey = settingsKey;
picker.possibleGroups = [
{key: 'a', label: 'A'},
{key: 'b', label: 'B'},
@@ -22,6 +24,7 @@ tr.b.unittest.testSuite(function() {
{key: 'd', label: 'D'},
{key: 'e', label: 'E'}
];
+ assert.deepEqual([], picker.currentGroupKeys);
this.addHTMLOutput(picker);
var keys = ['a', 'b', 'c', 'd', 'e'];
@@ -39,6 +42,14 @@ tr.b.unittest.testSuite(function() {
var keys = ['a', 'b', 'd'];
picker.currentGroupKeys = keys;
assert.deepEqual(keys, picker.currentGroupKeys);
+
+ tr.b.Settings.set(settingsKey, ['foo']);
+ picker.settingsKey = settingsKey;
+ assert.deepEqual([], picker.currentGroupKeys);
+
+ tr.b.Settings.set(settingsKey, ['e']);
+ picker.settingsKey = settingsKey;
+ assert.deepEqual(['e'], picker.currentGroupKeys);
});
});
</script>
« no previous file with comments | « tracing/tracing/ui/base/grouping_table_groupby_picker.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698