Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2480433002: Extend tweak_info_plist template to support multiple plist file as input. (Closed)

Created:
4 years, 1 month ago by sdefresne
Modified:
4 years, 1 month ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, cbentzel+watch_chromium.org, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Extend tweak_info_plist template to support multiple plist file as input. Rename build/config/mac/gen_plist.py to build/config/mac/plist_util.py after splitting the possible action (currently variable substitution and plist merging). Extend tweak_info_plist template to add another parameter info_plists corresponding to a list of path to merge before tweaking (this allow for adding partial plist files depending on configuration options). Always pass the --platform variable based on the value of $current_os to the tweak_info_plist template and make args optional. Refactor info_plist template to use separate steps for merge and variable substitution (as the script now implement them as two separate actions). BUG=613543 Committed: https://crrev.com/9bb379e5fbd071abaf1359d724eb79b1ff6e7ceb Cr-Commit-Position: refs/heads/master@{#429830}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+179 lines, -285 lines) Patch
M build/config/mac/base_rules.gni View 1 chunk +48 lines, -22 lines 0 comments Download
D build/config/mac/gen_plist.py View 1 chunk +0 lines, -209 lines 0 comments Download
A + build/config/mac/plist_util.py View 2 chunks +77 lines, -35 lines 0 comments Download
M build/mac/tweak_info_plist.gni View 2 chunks +54 lines, -17 lines 0 comments Download
M components/cronet/ios/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ios/crnet/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (7 generated)
sdefresne
Please take a look.
4 years, 1 month ago (2016-11-03 15:10:34 UTC) #4
Robert Sesek
LGTM
4 years, 1 month ago (2016-11-03 16:39:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2480433002/1
4 years, 1 month ago (2016-11-04 08:12:37 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-04 08:18:07 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-04 08:19:51 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9bb379e5fbd071abaf1359d724eb79b1ff6e7ceb
Cr-Commit-Position: refs/heads/master@{#429830}

Powered by Google App Engine
This is Rietveld 408576698