Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(914)

Unified Diff: build/config/mac/base_rules.gni

Issue 2480433002: Extend tweak_info_plist template to support multiple plist file as input. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/config/mac/gen_plist.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/mac/base_rules.gni
diff --git a/build/config/mac/base_rules.gni b/build/config/mac/base_rules.gni
index 266878ef7d0f829ea29977c4f1197f916c05d1dc..8adb6cca5205192f943390a4afb3e5f629d17bc8 100644
--- a/build/config/mac/base_rules.gni
+++ b/build/config/mac/base_rules.gni
@@ -93,36 +93,62 @@ template("info_plist") {
_output_name = invoker.output_name
}
- action(target_name) {
- script = "//build/config/mac/gen_plist.py"
+ _merged_name = get_path_info(_output_name, "dir") + "/" +
+ get_path_info(_output_name, "name") + "_merged" +
+ get_path_info(_output_name, "extension")
+
+ action(target_name + "_merge_templates") {
+ forward_variables_from(invoker,
+ [
+ "deps",
+ "testonly",
+ ])
+
+ script = "//build/config/mac/plist_util.py"
sources = invoker.plist_templates
outputs = [
- _output_name,
+ _merged_name,
]
- extra_args = []
- if (defined(invoker.extra_substitutions)) {
- foreach(substitution, invoker.extra_substitutions) {
- extra_args += [ "-s=$substitution" ]
- }
- }
- response_file_contents =
- extra_args + [
- "-s=BUILD_MACHINE_OS_BUILD=$machine_os_build",
- "-s=EXECUTABLE_NAME=$executable_name",
- "-s=GCC_VERSION=com.apple.compilers.llvm.clang.1_0",
- "-s=PRODUCT_NAME=$executable_name",
- "-s=XCODE_BUILD=$xcode_build",
- "-s=XCODE_VERSION=$xcode_version",
- "-o=" + rebase_path(_output_name, root_build_dir),
- "-f=" + invoker.format,
- ] + rebase_path(sources, root_build_dir)
- args = [ "@{{response_file_name}}" ]
+ args = [
+ "merge",
+ "-f=" + invoker.format,
+ "-o=" + rebase_path(_merged_name, root_build_dir),
+ ] + rebase_path(sources, root_build_dir)
+ }
+
+ action(target_name) {
forward_variables_from(invoker,
[
- "deps",
"testonly",
"visibility",
])
+ script = "//build/config/mac/plist_util.py"
+ sources = [
+ _merged_name,
+ ]
+ outputs = [
+ _output_name,
+ ]
+ args = [ "substitute" ]
+ if (defined(invoker.extra_substitutions)) {
+ foreach(substitution, invoker.extra_substitutions) {
+ args += [ "-s=$substitution" ]
+ }
+ }
+ args += [
+ "-s=BUILD_MACHINE_OS_BUILD=$machine_os_build",
+ "-s=EXECUTABLE_NAME=$executable_name",
+ "-s=GCC_VERSION=com.apple.compilers.llvm.clang.1_0",
+ "-s=PRODUCT_NAME=$executable_name",
+ "-s=XCODE_BUILD=$xcode_build",
+ "-s=XCODE_VERSION=$xcode_version",
+ "-o=" + rebase_path(_output_name, root_build_dir),
+ "-t=" + rebase_path(_merged_name, root_build_dir),
+ "-f=" + invoker.format,
+ ]
+ deps = [
+ ":" + target_name + "_merge_templates",
+ ]
}
}
« no previous file with comments | « no previous file | build/config/mac/gen_plist.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698