Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2473483011:
Add optional parameter entitlements_targets to iOS template. (Closed)
DescriptionAdd optional parameter entitlements_targets to iOS template.
Both ios_app_bundle and create_signed_bundle now accept another
optional parameter entitlements_targets (incompatible with the
entitlements_path parameter). This allow for generating the
entitlements file to use at build time.
BUG=613543
Committed: https://crrev.com/a2edd2b924e9f3539c740d5d7323b3ececb54cbb
Cr-Commit-Position: refs/heads/master@{#430239}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Address comments #Messages
Total messages: 24 (15 generated)
The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run
sdefresne@chromium.org changed reviewers: + olivierrobin@chromium.org
Please take a look and send to CQ if LGTY.
The CQ bit was unchecked by sdefresne@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Add optional parameter entitlements_targets to iOS template. Both ios_app_bundle and create_signed_bundle now accept another optional parameter entitlements_targets (incompatible with the entitlements_path parameter). This allow for generating the entitlements file to use at build time. BUG=613543 ========== to ========== Add optional parameter entitlements_targets to iOS template. Both ios_app_bundle and create_signed_bundle now accept another optional parameter entitlements_targets (incompatible with the entitlements_path parameter). This allow for generating the entitlements file to use at build time. BUG=613543 ==========
sdefresne@chromium.org changed reviewers: + dpranke@chromium.org - olivierrobin@chromium.org
-olivierrobin, +dpranke: sorry wrong reviewers. Please take a look and send to CQ if LGTY.
The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run
The CQ bit was unchecked by sdefresne@chromium.org
olivierrobin@chromium.org changed reviewers: + olivierrobin@chromium.org
https://codereview.chromium.org/2473483011/diff/1/build/config/ios/rules.gni File build/config/ios/rules.gni (right): https://codereview.chromium.org/2473483011/diff/1/build/config/ios/rules.gni#... build/config/ios/rules.gni:204: _entitlements_path = _entitlements_target_outputs[0] Should it be documented somewhere that target that generate entitlements must put it in the first output? Can there be a way to specify what output to consider?
On 2016/11/04 08:49:39, Olivier Robin wrote: > https://codereview.chromium.org/2473483011/diff/1/build/config/ios/rules.gni > File build/config/ios/rules.gni (right): > > https://codereview.chromium.org/2473483011/diff/1/build/config/ios/rules.gni#... > build/config/ios/rules.gni:204: _entitlements_path = > _entitlements_target_outputs[0] > Should it be documented somewhere that target that generate entitlements must > put it in the first output? > Can there be a way to specify what output to consider? This is how it is done with info_plist_target and not documented either. The target is expected to only have one output.
lgtm w/ comment addressed. https://codereview.chromium.org/2473483011/diff/1/build/config/ios/rules.gni File build/config/ios/rules.gni (right): https://codereview.chromium.org/2473483011/diff/1/build/config/ios/rules.gni#... build/config/ios/rules.gni:204: _entitlements_path = _entitlements_target_outputs[0] On 2016/11/04 08:49:39, Olivier Robin wrote: > Should it be documented somewhere that target that generate entitlements must > put it in the first output? > Can there be a way to specify what output to consider? Seems like a good suggestion (at least the first part, about documenting).
The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by sdefresne@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org Link to the patchset: https://codereview.chromium.org/2473483011/#ps20001 (title: "Address comments")
On 2016/11/04 17:12:11, Dirk Pranke wrote: > lgtm w/ comment addressed. > > https://codereview.chromium.org/2473483011/diff/1/build/config/ios/rules.gni > File build/config/ios/rules.gni (right): > > https://codereview.chromium.org/2473483011/diff/1/build/config/ios/rules.gni#... > build/config/ios/rules.gni:204: _entitlements_path = > _entitlements_target_outputs[0] > On 2016/11/04 08:49:39, Olivier Robin wrote: > > Should it be documented somewhere that target that generate entitlements must > > put it in the first output? > > Can there be a way to specify what output to consider? > > Seems like a good suggestion (at least the first part, about documenting). Done.
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Add optional parameter entitlements_targets to iOS template. Both ios_app_bundle and create_signed_bundle now accept another optional parameter entitlements_targets (incompatible with the entitlements_path parameter). This allow for generating the entitlements file to use at build time. BUG=613543 ========== to ========== Add optional parameter entitlements_targets to iOS template. Both ios_app_bundle and create_signed_bundle now accept another optional parameter entitlements_targets (incompatible with the entitlements_path parameter). This allow for generating the entitlements file to use at build time. BUG=613543 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Add optional parameter entitlements_targets to iOS template. Both ios_app_bundle and create_signed_bundle now accept another optional parameter entitlements_targets (incompatible with the entitlements_path parameter). This allow for generating the entitlements file to use at build time. BUG=613543 ========== to ========== Add optional parameter entitlements_targets to iOS template. Both ios_app_bundle and create_signed_bundle now accept another optional parameter entitlements_targets (incompatible with the entitlements_path parameter). This allow for generating the entitlements file to use at build time. BUG=613543 Committed: https://crrev.com/a2edd2b924e9f3539c740d5d7323b3ececb54cbb Cr-Commit-Position: refs/heads/master@{#430239} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/a2edd2b924e9f3539c740d5d7323b3ececb54cbb Cr-Commit-Position: refs/heads/master@{#430239} |
