Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ui/gl/gl_context_osmesa.cc

Issue 2480373002: Refactor context creation parameters into a struct. (Closed)
Patch Set: address piman's comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« android_webview/browser/test/fake_window.cc ('K') | « ui/gl/gl_context_osmesa.h ('k') | ui/gl/gl_context_stub.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gl/gl_context_osmesa.cc
diff --git a/ui/gl/gl_context_osmesa.cc b/ui/gl/gl_context_osmesa.cc
index ff05eedb152d527606e93b53f178594d0462d7bd..1f998d8789756dcb0fc2aa423c23f4d7ce0c4751 100644
--- a/ui/gl/gl_context_osmesa.cc
+++ b/ui/gl/gl_context_osmesa.cc
@@ -20,7 +20,12 @@ GLContextOSMesa::GLContextOSMesa(GLShareGroup* share_group)
}
bool GLContextOSMesa::Initialize(GLSurface* compatible_surface,
- GpuPreference gpu_preference) {
+ const GLContextAttribs& attribs) {
+ // webgl_compatibility_context and disabling bind_generates_resource are not
+ // supported.
+ DCHECK(!attribs.webgl_compatibility_context &&
+ attribs.bind_generates_resource);
+
DCHECK(!context_);
OSMesaContext share_handle = static_cast<OSMesaContext>(
« android_webview/browser/test/fake_window.cc ('K') | « ui/gl/gl_context_osmesa.h ('k') | ui/gl/gl_context_stub.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698