android_webview/browser/test/fake_window.cc - Issue 2480373002: Refactor context creation parameters into a struct.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/browser/test/fake_window.cc

Issue 2480373002: Refactor context creation parameters into a struct. (Closed)

Patch Set: address piman's comments Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: android_webview/browser/test/fake_window.cc

diff --git a/android_webview/browser/test/fake_window.cc b/android_webview/browser/test/fake_window.cc

index cd47a3c93e4beef8ec747100e7afcf5b04688a0c..411ee217352a1235a529a24663e0104da913147c 100644

--- a/android_webview/browser/test/fake_window.cc

+++ b/android_webview/browser/test/fake_window.cc

@@ -189,8 +189,8 @@ void FakeWindow::InitializeOnRT(base::WaitableEvent* sync) {

surface_ = gl::init::CreateOffscreenGLSurface(surface_size_);

DCHECK(surface_);

DCHECK(surface_->GetHandle());

- context_ =

- gl::init::CreateGLContext(nullptr, surface_.get(), gl::PreferDiscreteGpu);

+ context_ = gl::init::CreateGLContext(nullptr, surface_.get(),

+ gl::GLContextAttribs());

Torne 2016/11/08 14:34:29 Same here

DCHECK(context_);

sync->Signal();

}