Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Side by Side Diff: ui/gl/gl_context_osmesa.cc

Issue 2480373002: Refactor context creation parameters into a struct. (Closed)
Patch Set: address piman's comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ui/gl/gl_context_osmesa.h" 5 #include "ui/gl/gl_context_osmesa.h"
6 6
7 #include <GL/osmesa.h> 7 #include <GL/osmesa.h>
8 8
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "ui/gfx/geometry/size.h" 10 #include "ui/gfx/geometry/size.h"
11 #include "ui/gl/gl_bindings.h" 11 #include "ui/gl/gl_bindings.h"
12 #include "ui/gl/gl_surface.h" 12 #include "ui/gl/gl_surface.h"
13 13
14 namespace gl { 14 namespace gl {
15 15
16 GLContextOSMesa::GLContextOSMesa(GLShareGroup* share_group) 16 GLContextOSMesa::GLContextOSMesa(GLShareGroup* share_group)
17 : GLContextReal(share_group), 17 : GLContextReal(share_group),
18 context_(nullptr), 18 context_(nullptr),
19 is_released_(false) { 19 is_released_(false) {
20 } 20 }
21 21
22 bool GLContextOSMesa::Initialize(GLSurface* compatible_surface, 22 bool GLContextOSMesa::Initialize(GLSurface* compatible_surface,
23 GpuPreference gpu_preference) { 23 const GLContextAttribs& attribs) {
24 // webgl_compatibility_context and disabling bind_generates_resource are not
25 // supported.
26 DCHECK(!attribs.webgl_compatibility_context &&
27 attribs.bind_generates_resource);
28
24 DCHECK(!context_); 29 DCHECK(!context_);
25 30
26 OSMesaContext share_handle = static_cast<OSMesaContext>( 31 OSMesaContext share_handle = static_cast<OSMesaContext>(
27 share_group() ? share_group()->GetHandle() : nullptr); 32 share_group() ? share_group()->GetHandle() : nullptr);
28 33
29 GLuint format = 0; 34 GLuint format = 0;
30 switch (compatible_surface->GetFormat()) { 35 switch (compatible_surface->GetFormat()) {
31 case GLSurface::SURFACE_OSMESA_BGRA: 36 case GLSurface::SURFACE_OSMESA_BGRA:
32 format = OSMESA_BGRA; 37 format = OSMESA_BGRA;
33 break; 38 break;
(...skipping 108 matching lines...) Expand 10 before | Expand all | Expand 10 after
142 147
143 void GLContextOSMesa::OnSetSwapInterval(int interval) { 148 void GLContextOSMesa::OnSetSwapInterval(int interval) {
144 DCHECK(IsCurrent(nullptr)); 149 DCHECK(IsCurrent(nullptr));
145 } 150 }
146 151
147 GLContextOSMesa::~GLContextOSMesa() { 152 GLContextOSMesa::~GLContextOSMesa() {
148 Destroy(); 153 Destroy();
149 } 154 }
150 155
151 } // namespace gl 156 } // namespace gl
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698