Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1752)

Unified Diff: third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerProvider.h

Issue 2480293004: Mandate unique_ptr for base::IDMap in IDMapOwnPointer mode. (Closed)
Patch Set: Make changes requested by danakj, fix a few more headers Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerProvider.h
diff --git a/third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerProvider.h b/third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerProvider.h
index cb921090f9dfb4df1979b8ce927fe163cb2123f2..08885fa04018f6eee55d9c02c89b005297ab7020 100644
--- a/third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerProvider.h
+++ b/third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerProvider.h
@@ -67,14 +67,17 @@ class WebServiceWorkerProvider {
using WebServiceWorkerGetRegistrationForReadyCallbacks =
WebCallbacks<std::unique_ptr<WebServiceWorkerRegistration::Handle>, void>;
- virtual void registerServiceWorker(const WebURL& pattern,
- const WebURL& scriptUrl,
- WebServiceWorkerRegistrationCallbacks*) {}
- virtual void getRegistration(const WebURL& documentURL,
- WebServiceWorkerGetRegistrationCallbacks*) {}
- virtual void getRegistrations(WebServiceWorkerGetRegistrationsCallbacks*) {}
+ virtual void registerServiceWorker(
+ const WebURL& pattern,
+ const WebURL& scriptUrl,
+ std::unique_ptr<WebServiceWorkerRegistrationCallbacks>) {}
+ virtual void getRegistration(
+ const WebURL& documentURL,
+ std::unique_ptr<WebServiceWorkerGetRegistrationCallbacks>) {}
+ virtual void getRegistrations(
+ std::unique_ptr<WebServiceWorkerGetRegistrationsCallbacks>) {}
virtual void getRegistrationForReady(
- WebServiceWorkerGetRegistrationForReadyCallbacks*) {}
+ std::unique_ptr<WebServiceWorkerGetRegistrationForReadyCallbacks>) {}
virtual bool validateScopeAndScriptURL(const WebURL& scope,
const WebURL& scriptURL,
WebString* errorMessage) {

Powered by Google App Engine
This is Rietveld 408576698