Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerRegistration.h

Issue 2480293004: Mandate unique_ptr for base::IDMap in IDMapOwnPointer mode. (Closed)
Patch Set: Make changes requested by danakj, fix a few more headers Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerRegistration.h
diff --git a/third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerRegistration.h b/third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerRegistration.h
index d2f45a960bfdcf9dd1e199347e68b7a1b2e75573..2f9ee552b473abfcea0ead55a9c85383f51c61bc 100644
--- a/third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerRegistration.h
+++ b/third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerRegistration.h
@@ -8,6 +8,7 @@
#include "public/platform/WebCallbacks.h"
#include "public/platform/WebURL.h"
#include "public/platform/modules/serviceworker/WebServiceWorkerError.h"
+#include <memory>
namespace blink {
@@ -52,9 +53,10 @@ class WebServiceWorkerRegistration {
virtual WebURL scope() const { return WebURL(); }
virtual int64_t registrationId() const = 0;
virtual void update(WebServiceWorkerProvider*,
- WebServiceWorkerUpdateCallbacks*) {}
- virtual void unregister(WebServiceWorkerProvider*,
- WebServiceWorkerUnregistrationCallbacks*) {}
+ std::unique_ptr<WebServiceWorkerUpdateCallbacks>) {}
+ virtual void unregister(
+ WebServiceWorkerProvider*,
+ std::unique_ptr<WebServiceWorkerUnregistrationCallbacks>) {}
virtual void enableNavigationPreload(
bool enable,

Powered by Google App Engine
This is Rietveld 408576698