third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerCacheStorage.h - Issue 2480293004: Mandate unique_ptr for base::IDMap in IDMapOwnPointer mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerCacheStorage.h

Issue 2480293004: Mandate unique_ptr for base::IDMap in IDMapOwnPointer mode. (Closed)

Patch Set: Make changes requested by danakj, fix a few more headers Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerCache.h ('k') | third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerProvider.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerCacheStorage.h

diff --git a/third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerCacheStorage.h b/third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerCacheStorage.h

index e80412d176736a28baf818f924c91f9f395dc676..7e1d658407f99ae0183a204f4fb3bb45b3df4b52 100644

--- a/third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerCacheStorage.h

+++ b/third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerCacheStorage.h

@@ -41,14 +41,14 @@ class WebServiceWorkerCacheStorage {

// dispatchOpen() can return a WebServiceWorkerCache object. These objects

// are owned by Blink and should be destroyed when they are no longer needed.

- virtual void dispatchHas(CacheStorageCallbacks*,

+ virtual void dispatchHas(std::unique_ptr<CacheStorageCallbacks>,

const WebString& cacheName) = 0;

- virtual void dispatchOpen(CacheStorageWithCacheCallbacks*,

+ virtual void dispatchOpen(std::unique_ptr<CacheStorageWithCacheCallbacks>,

const WebString& cacheName) = 0;

- virtual void dispatchDelete(CacheStorageCallbacks*,

+ virtual void dispatchDelete(std::unique_ptr<CacheStorageCallbacks>,

const WebString& cacheName) = 0;

- virtual void dispatchKeys(CacheStorageKeysCallbacks*) = 0;

- virtual void dispatchMatch(CacheStorageMatchCallbacks*,

+ virtual void dispatchKeys(std::unique_ptr<CacheStorageKeysCallbacks>) = 0;

+ virtual void dispatchMatch(std::unique_ptr<CacheStorageMatchCallbacks>,

const WebServiceWorkerRequest&,

const WebServiceWorkerCache::QueryParams&) = 0;

};