Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Unified Diff: third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerCache.h

Issue 2480293004: Mandate unique_ptr for base::IDMap in IDMapOwnPointer mode. (Closed)
Patch Set: Make changes requested by danakj, fix a few more headers Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerCache.h
diff --git a/third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerCache.h b/third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerCache.h
index ff361bb80909c063efe7fc9f21150c195349f81b..8d2dfba0c58b1dfcd97ebd3f0a8e9c8bde11eb76 100644
--- a/third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerCache.h
+++ b/third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerCache.h
@@ -12,6 +12,8 @@
#include "public/platform/modules/serviceworker/WebServiceWorkerCacheError.h"
#include "public/platform/modules/serviceworker/WebServiceWorkerRequest.h"
#include "public/platform/modules/serviceworker/WebServiceWorkerResponse.h"
+#include <memory>
+#include <utility>
namespace blink {
@@ -65,16 +67,16 @@ class WebServiceWorkerCache {
// Ownership of the Cache*Callbacks methods passes to the
// WebServiceWorkerCache instance, which will delete it after calling
// onSuccess or onFailure.
- virtual void dispatchMatch(CacheMatchCallbacks*,
+ virtual void dispatchMatch(std::unique_ptr<CacheMatchCallbacks>,
const WebServiceWorkerRequest&,
const QueryParams&) = 0;
- virtual void dispatchMatchAll(CacheWithResponsesCallbacks*,
+ virtual void dispatchMatchAll(std::unique_ptr<CacheWithResponsesCallbacks>,
const WebServiceWorkerRequest&,
const QueryParams&) = 0;
- virtual void dispatchKeys(CacheWithRequestsCallbacks*,
+ virtual void dispatchKeys(std::unique_ptr<CacheWithRequestsCallbacks>,
const WebServiceWorkerRequest&,
const QueryParams&) = 0;
- virtual void dispatchBatch(CacheBatchCallbacks*,
+ virtual void dispatchBatch(std::unique_ptr<CacheBatchCallbacks>,
const WebVector<BatchOperation>&) = 0;
};

Powered by Google App Engine
This is Rietveld 408576698