third_party/WebKit/public/platform/modules/screen_orientation/WebScreenOrientationClient.h - Issue 2480293004: Mandate unique_ptr for base::IDMap in IDMapOwnPointer mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/public/platform/modules/screen_orientation/WebScreenOrientationClient.h

Issue 2480293004: Mandate unique_ptr for base::IDMap in IDMapOwnPointer mode. (Closed)

Patch Set: Make changes requested by danakj, fix a few more headers Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/public/platform/modules/push_messaging/WebPushProvider.h ('k') | third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerCache.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/public/platform/modules/screen_orientation/WebScreenOrientationClient.h

diff --git a/third_party/WebKit/public/platform/modules/screen_orientation/WebScreenOrientationClient.h b/third_party/WebKit/public/platform/modules/screen_orientation/WebScreenOrientationClient.h

index 81f46101993f615b95fae9822376d261a7424956..3530bfc686b83b11cafad6b9481483cde0e914f5 100644

--- a/third_party/WebKit/public/platform/modules/screen_orientation/WebScreenOrientationClient.h

+++ b/third_party/WebKit/public/platform/modules/screen_orientation/WebScreenOrientationClient.h

@@ -6,6 +6,7 @@

#define WebScreenOrientationClient_h

#include "public/platform/modules/screen_orientation/WebScreenOrientationLockType.h"

+#include <memory>

namespace blink {

@@ -19,7 +20,7 @@ class WebScreenOrientationClient {

// Request a screen orientation lock. The implementation will own the

// callback.

virtual void lockOrientation(WebScreenOrientationLockType,

- WebLockOrientationCallback*) = 0;

+ std::unique_ptr<WebLockOrientationCallback>) = 0;

// Unlock the screen orientation. No-op if the screen orientation was not

// locked.