Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Unified Diff: third_party/WebKit/public/platform/modules/push_messaging/WebPushProvider.h

Issue 2480293004: Mandate unique_ptr for base::IDMap in IDMapOwnPointer mode. (Closed)
Patch Set: Make changes requested by danakj, fix a few more headers Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/public/platform/modules/push_messaging/WebPushProvider.h
diff --git a/third_party/WebKit/public/platform/modules/push_messaging/WebPushProvider.h b/third_party/WebKit/public/platform/modules/push_messaging/WebPushProvider.h
index 5b1540071a542bb4db8457d0eaefe6ea2ee7b4d3..3fff7f4e6f66c0fc12ffa84ee9ed5d13e2c47563 100644
--- a/third_party/WebKit/public/platform/modules/push_messaging/WebPushProvider.h
+++ b/third_party/WebKit/public/platform/modules/push_messaging/WebPushProvider.h
@@ -31,23 +31,25 @@ class WebPushProvider {
// Does not take ownership of the WebServiceWorkerRegistration.
virtual void subscribe(WebServiceWorkerRegistration*,
const WebPushSubscriptionOptions&,
- WebPushSubscriptionCallbacks*) = 0;
+ std::unique_ptr<WebPushSubscriptionCallbacks>) = 0;
// Takes ownership of the WebPushSubscriptionCallbacks.
// Does not take ownership of the WebServiceWorkerRegistration.
- virtual void getSubscription(WebServiceWorkerRegistration*,
- WebPushSubscriptionCallbacks*) = 0;
+ virtual void getSubscription(
+ WebServiceWorkerRegistration*,
+ std::unique_ptr<WebPushSubscriptionCallbacks>) = 0;
// Takes ownership of the WebPushPermissionStatusCallbacks.
// Does not take ownership of the WebServiceWorkerRegistration.
- virtual void getPermissionStatus(WebServiceWorkerRegistration*,
- const WebPushSubscriptionOptions&,
- WebPushPermissionStatusCallbacks*) = 0;
+ virtual void getPermissionStatus(
+ WebServiceWorkerRegistration*,
+ const WebPushSubscriptionOptions&,
+ std::unique_ptr<WebPushPermissionStatusCallbacks>) = 0;
// Takes ownership if the WebPushUnsubscribeCallbacks.
// Does not take ownership of the WebServiceWorkerRegistration.
virtual void unsubscribe(WebServiceWorkerRegistration*,
- WebPushUnsubscribeCallbacks*) = 0;
+ std::unique_ptr<WebPushUnsubscribeCallbacks>) = 0;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698