third_party/WebKit/public/platform/modules/push_messaging/WebPushClient.h - Issue 2480293004: Mandate unique_ptr for base::IDMap in IDMapOwnPointer mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/public/platform/modules/push_messaging/WebPushClient.h

Issue 2480293004: Mandate unique_ptr for base::IDMap in IDMapOwnPointer mode. (Closed)

Patch Set: Make changes requested by danakj, fix a few more headers Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/public/platform/modules/presentation/WebPresentationClient.h ('k') | third_party/WebKit/public/platform/modules/push_messaging/WebPushProvider.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/public/platform/modules/push_messaging/WebPushClient.h

diff --git a/third_party/WebKit/public/platform/modules/push_messaging/WebPushClient.h b/third_party/WebKit/public/platform/modules/push_messaging/WebPushClient.h

index 7d0c53699da3280e6f919127ea0de4f2c4cddf76..8f70597b807596ca53f123b41ecd68d037eb42a0 100644

--- a/third_party/WebKit/public/platform/modules/push_messaging/WebPushClient.h

+++ b/third_party/WebKit/public/platform/modules/push_messaging/WebPushClient.h

@@ -8,6 +8,7 @@

#include "public/platform/WebCallbacks.h"

#include "public/platform/modules/push_messaging/WebPushError.h"

#include "public/platform/modules/push_messaging/WebPushProvider.h"

+#include <memory>

namespace blink {

@@ -23,7 +24,7 @@ class WebPushClient {

// Ownership of the callbacks is transferred to the client.

virtual void subscribe(WebServiceWorkerRegistration*,

const WebPushSubscriptionOptions&,

- WebPushSubscriptionCallbacks*) = 0;

+ std::unique_ptr<WebPushSubscriptionCallbacks>) = 0;

};

} // namespace blink