Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(604)

Unified Diff: third_party/WebKit/public/platform/modules/presentation/WebPresentationClient.h

Issue 2480293004: Mandate unique_ptr for base::IDMap in IDMapOwnPointer mode. (Closed)
Patch Set: Make changes requested by danakj, fix a few more headers Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/public/platform/modules/presentation/WebPresentationClient.h
diff --git a/third_party/WebKit/public/platform/modules/presentation/WebPresentationClient.h b/third_party/WebKit/public/platform/modules/presentation/WebPresentationClient.h
index a8d57d473241c1324439cf4c3aeb9d2ac64ac982..41527229b90d05791cc5a82f6dc43a706d087e33 100644
--- a/third_party/WebKit/public/platform/modules/presentation/WebPresentationClient.h
+++ b/third_party/WebKit/public/platform/modules/presentation/WebPresentationClient.h
@@ -46,15 +46,15 @@ class WebPresentationClient {
virtual void setReceiver(WebPresentationReceiver*) = 0;
// Called when the frame requests to start a new session.
- // The ownership of the |callbacks| argument is transferred to the embedder.
- virtual void startSession(const WebVector<WebURL>& presentationUrls,
- WebPresentationConnectionClientCallbacks*) = 0;
+ virtual void startSession(
+ const WebVector<WebURL>& presentationUrls,
+ std::unique_ptr<WebPresentationConnectionClientCallbacks>) = 0;
// Called when the frame requests to join an existing session.
- // The ownership of the |callbacks| argument is transferred to the embedder.
- virtual void joinSession(const WebVector<WebURL>& presentationUrls,
- const WebString& presentationId,
- WebPresentationConnectionClientCallbacks*) = 0;
+ virtual void joinSession(
+ const WebVector<WebURL>& presentationUrls,
+ const WebString& presentationId,
+ std::unique_ptr<WebPresentationConnectionClientCallbacks>) = 0;
// Called when the frame requests to send String message to an existing
// session.
@@ -85,10 +85,10 @@ class WebPresentationClient {
const WebString& presentationId) = 0;
// Called when the frame wants to know the availability of a presentation
- // display for |availabilityUrl|. The ownership of the callbacks argument
- // is transferred to the embedder.
- virtual void getAvailability(const WebURL& availabilityUrl,
- WebPresentationAvailabilityCallbacks*) = 0;
+ // display for |availabilityUrl|.
+ virtual void getAvailability(
+ const WebURL& availabilityUrl,
+ std::unique_ptr<WebPresentationAvailabilityCallbacks>) = 0;
// Start listening to changes in presentation displays availability. The
// observer will be notified in case of a change. The observer is

Powered by Google App Engine
This is Rietveld 408576698