Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Unified Diff: third_party/WebKit/public/platform/modules/notifications/WebNotificationManager.h

Issue 2480293004: Mandate unique_ptr for base::IDMap in IDMapOwnPointer mode. (Closed)
Patch Set: Make changes requested by danakj, fix a few more headers Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/public/platform/modules/notifications/WebNotificationManager.h
diff --git a/third_party/WebKit/public/platform/modules/notifications/WebNotificationManager.h b/third_party/WebKit/public/platform/modules/notifications/WebNotificationManager.h
index 20aa454aff0e34d66ad5479f64c958254ea1eb6a..cecb5b84f9b3393381c057e6685265f19d13c763 100644
--- a/third_party/WebKit/public/platform/modules/notifications/WebNotificationManager.h
+++ b/third_party/WebKit/public/platform/modules/notifications/WebNotificationManager.h
@@ -45,19 +45,21 @@ class WebNotificationManager {
// will have their events delivered to a Service Worker rather than the
// object's delegate. Will take ownership of the WebNotificationShowCallbacks
// object.
- virtual void showPersistent(const WebSecurityOrigin&,
- const WebNotificationData&,
- std::unique_ptr<WebNotificationResources>,
- WebServiceWorkerRegistration*,
- WebNotificationShowCallbacks*) = 0;
+ virtual void showPersistent(
+ const WebSecurityOrigin&,
+ const WebNotificationData&,
+ std::unique_ptr<WebNotificationResources>,
+ WebServiceWorkerRegistration*,
+ std::unique_ptr<WebNotificationShowCallbacks>) = 0;
// Asynchronously gets the persistent notifications belonging to the Service
// Worker Registration. If |filterTag| is not an empty string, only the
// notification with the given tag will be considered. Will take ownership of
// the WebNotificationGetCallbacks object.
- virtual void getNotifications(const WebString& filterTag,
- WebServiceWorkerRegistration*,
- WebNotificationGetCallbacks*) = 0;
+ virtual void getNotifications(
+ const WebString& filterTag,
+ WebServiceWorkerRegistration*,
+ std::unique_ptr<WebNotificationGetCallbacks>) = 0;
// Closes a notification previously shown, and removes it if being shown.
virtual void close(WebNotificationDelegate*) = 0;

Powered by Google App Engine
This is Rietveld 408576698