Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: third_party/WebKit/Source/web/WebEmbeddedWorkerImplTest.cpp

Issue 2480293004: Mandate unique_ptr for base::IDMap in IDMapOwnPointer mode. (Closed)
Patch Set: Make changes requested by danakj, fix a few more headers Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebEmbeddedWorkerImplTest.cpp
diff --git a/third_party/WebKit/Source/web/WebEmbeddedWorkerImplTest.cpp b/third_party/WebKit/Source/web/WebEmbeddedWorkerImplTest.cpp
index ffbf64aa2baaa144d604c254452e48fa94590aa2..bd97cc6e0a49b225a1859a32f115d50a093cf11f 100644
--- a/third_party/WebKit/Source/web/WebEmbeddedWorkerImplTest.cpp
+++ b/third_party/WebKit/Source/web/WebEmbeddedWorkerImplTest.cpp
@@ -38,14 +38,16 @@ class MockServiceWorkerContextClient : public WebServiceWorkerContextClient {
void setHasAssociatedRegistration(bool hasAssociatedRegistration) {
m_hasAssociatedRegistration = hasAssociatedRegistration;
}
- void getClient(const WebString&, WebServiceWorkerClientCallbacks*) override {
+ void getClient(const WebString&,
+ std::unique_ptr<WebServiceWorkerClientCallbacks>) override {
NOTREACHED();
}
void getClients(const WebServiceWorkerClientQueryOptions&,
- WebServiceWorkerClientsCallbacks*) override {
+ std::unique_ptr<WebServiceWorkerClientsCallbacks>) override {
NOTREACHED();
}
- void openWindow(const WebURL&, WebServiceWorkerClientCallbacks*) override {
+ void openWindow(const WebURL&,
+ std::unique_ptr<WebServiceWorkerClientCallbacks>) override {
NOTREACHED();
}
void postMessageToClient(const WebString& uuid,
@@ -58,16 +60,20 @@ class MockServiceWorkerContextClient : public WebServiceWorkerContextClient {
WebMessagePortChannelArray*) override {
NOTREACHED();
}
- void skipWaiting(WebServiceWorkerSkipWaitingCallbacks*) override {
+ void skipWaiting(
+ std::unique_ptr<WebServiceWorkerSkipWaitingCallbacks>) override {
NOTREACHED();
}
- void claim(WebServiceWorkerClientsClaimCallbacks*) override { NOTREACHED(); }
- void focus(const WebString& uuid, WebServiceWorkerClientCallbacks*) override {
+ void claim(std::unique_ptr<WebServiceWorkerClientsClaimCallbacks>) override {
+ NOTREACHED();
+ }
+ void focus(const WebString& uuid,
+ std::unique_ptr<WebServiceWorkerClientCallbacks>) override {
NOTREACHED();
}
void navigate(const WebString& uuid,
const WebURL&,
- WebServiceWorkerClientCallbacks*) override {
+ std::unique_ptr<WebServiceWorkerClientCallbacks>) override {
NOTREACHED();
}
void registerForeignFetchScopes(

Powered by Google App Engine
This is Rietveld 408576698