content/child/service_worker/web_service_worker_registration_impl.h - Issue 2480293004: Mandate unique_ptr for base::IDMap in IDMapOwnPointer mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/service_worker/web_service_worker_registration_impl.h

Issue 2480293004: Mandate unique_ptr for base::IDMap in IDMapOwnPointer mode. (Closed)

Patch Set: Make changes requested by danakj, fix a few more headers Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/child/service_worker/web_service_worker_provider_impl.cc ('k') | content/child/service_worker/web_service_worker_registration_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/child/service_worker/web_service_worker_registration_impl.h

diff --git a/content/child/service_worker/web_service_worker_registration_impl.h b/content/child/service_worker/web_service_worker_registration_impl.h

index ce30fb00eae8dec1cf096f951825d3d01fa9f00f..46144444da79d7e0309ff9e7ab6a488b10ec8d4c 100644

--- a/content/child/service_worker/web_service_worker_registration_impl.h

+++ b/content/child/service_worker/web_service_worker_registration_impl.h

@@ -49,10 +49,12 @@ class CONTENT_EXPORT WebServiceWorkerRegistrationImpl

void setProxy(blink::WebServiceWorkerRegistrationProxy* proxy) override;

blink::WebServiceWorkerRegistrationProxy* proxy() override;

blink::WebURL scope() const override;

- void update(blink::WebServiceWorkerProvider* provider,

- WebServiceWorkerUpdateCallbacks* callbacks) override;

+ void update(

+ blink::WebServiceWorkerProvider* provider,

+ std::unique_ptr<WebServiceWorkerUpdateCallbacks> callbacks) override;

void unregister(blink::WebServiceWorkerProvider* provider,

- WebServiceWorkerUnregistrationCallbacks* callbacks) override;

+ std::unique_ptr<WebServiceWorkerUnregistrationCallbacks>

+ callbacks) override;

void enableNavigationPreload(

bool enable,

blink::WebServiceWorkerProvider* provider,