Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: content/child/service_worker/web_service_worker_provider_impl.cc

Issue 2480293004: Mandate unique_ptr for base::IDMap in IDMapOwnPointer mode. (Closed)
Patch Set: Make changes requested by danakj, fix a few more headers Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/child/service_worker/web_service_worker_provider_impl.cc
diff --git a/content/child/service_worker/web_service_worker_provider_impl.cc b/content/child/service_worker/web_service_worker_provider_impl.cc
index 5d5e8f7d5ea2dcb0c1a8c5b34304973dc1f4b0cf..e2a2574c6ee8dd95dd08758f12c36cd6c934f565 100644
--- a/content/child/service_worker/web_service_worker_provider_impl.cc
+++ b/content/child/service_worker/web_service_worker_provider_impl.cc
@@ -4,6 +4,9 @@
#include "content/child/service_worker/web_service_worker_provider_impl.h"
+#include <memory>
+#include <utility>
+
#include "content/child/service_worker/service_worker_dispatcher.h"
#include "content/child/service_worker/service_worker_handle_reference.h"
#include "content/child/service_worker/service_worker_provider_context.h"
@@ -57,27 +60,29 @@ void WebServiceWorkerProviderImpl::setClient(
void WebServiceWorkerProviderImpl::registerServiceWorker(
const WebURL& pattern,
const WebURL& script_url,
- WebServiceWorkerRegistrationCallbacks* callbacks) {
- GetDispatcher()->RegisterServiceWorker(
- context_->provider_id(), pattern, script_url, callbacks);
+ std::unique_ptr<WebServiceWorkerRegistrationCallbacks> callbacks) {
+ GetDispatcher()->RegisterServiceWorker(context_->provider_id(), pattern,
+ script_url, std::move(callbacks));
}
void WebServiceWorkerProviderImpl::getRegistration(
const blink::WebURL& document_url,
- WebServiceWorkerGetRegistrationCallbacks* callbacks) {
- GetDispatcher()->GetRegistration(
- context_->provider_id(), document_url, callbacks);
+ std::unique_ptr<WebServiceWorkerGetRegistrationCallbacks> callbacks) {
+ GetDispatcher()->GetRegistration(context_->provider_id(), document_url,
+ std::move(callbacks));
}
void WebServiceWorkerProviderImpl::getRegistrations(
- WebServiceWorkerGetRegistrationsCallbacks* callbacks) {
- GetDispatcher()->GetRegistrations(
- context_->provider_id(), callbacks);
+ std::unique_ptr<WebServiceWorkerGetRegistrationsCallbacks> callbacks) {
+ GetDispatcher()->GetRegistrations(context_->provider_id(),
+ std::move(callbacks));
}
void WebServiceWorkerProviderImpl::getRegistrationForReady(
- WebServiceWorkerGetRegistrationForReadyCallbacks* callbacks) {
- GetDispatcher()->GetRegistrationForReady(context_->provider_id(), callbacks);
+ std::unique_ptr<WebServiceWorkerGetRegistrationForReadyCallbacks>
+ callbacks) {
+ GetDispatcher()->GetRegistrationForReady(context_->provider_id(),
+ std::move(callbacks));
}
bool WebServiceWorkerProviderImpl::validateScopeAndScriptURL(

Powered by Google App Engine
This is Rietveld 408576698