Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(721)

Unified Diff: content/child/service_worker/web_service_worker_registration_impl.cc

Issue 2480293004: Mandate unique_ptr for base::IDMap in IDMapOwnPointer mode. (Closed)
Patch Set: Make changes requested by danakj, fix a few more headers Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/child/service_worker/web_service_worker_registration_impl.cc
diff --git a/content/child/service_worker/web_service_worker_registration_impl.cc b/content/child/service_worker/web_service_worker_registration_impl.cc
index 0b4d8149a1f71d3ecaa92c01d5c09de010a8303e..48d440e40c3eaa4614c84b9ed1fff8fc3b700208 100644
--- a/content/child/service_worker/web_service_worker_registration_impl.cc
+++ b/content/child/service_worker/web_service_worker_registration_impl.cc
@@ -125,26 +125,26 @@ blink::WebURL WebServiceWorkerRegistrationImpl::scope() const {
void WebServiceWorkerRegistrationImpl::update(
blink::WebServiceWorkerProvider* provider,
- WebServiceWorkerUpdateCallbacks* callbacks) {
+ std::unique_ptr<WebServiceWorkerUpdateCallbacks> callbacks) {
WebServiceWorkerProviderImpl* provider_impl =
static_cast<WebServiceWorkerProviderImpl*>(provider);
ServiceWorkerDispatcher* dispatcher =
ServiceWorkerDispatcher::GetThreadSpecificInstance();
DCHECK(dispatcher);
dispatcher->UpdateServiceWorker(provider_impl->provider_id(),
- registrationId(), callbacks);
+ registrationId(), std::move(callbacks));
}
void WebServiceWorkerRegistrationImpl::unregister(
blink::WebServiceWorkerProvider* provider,
- WebServiceWorkerUnregistrationCallbacks* callbacks) {
+ std::unique_ptr<WebServiceWorkerUnregistrationCallbacks> callbacks) {
WebServiceWorkerProviderImpl* provider_impl =
static_cast<WebServiceWorkerProviderImpl*>(provider);
ServiceWorkerDispatcher* dispatcher =
ServiceWorkerDispatcher::GetThreadSpecificInstance();
DCHECK(dispatcher);
dispatcher->UnregisterServiceWorker(provider_impl->provider_id(),
- registrationId(), callbacks);
+ registrationId(), std::move(callbacks));
}
void WebServiceWorkerRegistrationImpl::enableNavigationPreload(

Powered by Google App Engine
This is Rietveld 408576698