Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: content/child/service_worker/web_service_worker_registration_impl.cc

Issue 2480293004: Mandate unique_ptr for base::IDMap in IDMapOwnPointer mode. (Closed)
Patch Set: Make changes requested by danakj, fix a few more headers Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/child/service_worker/web_service_worker_registration_impl.h" 5 #include "content/child/service_worker/web_service_worker_registration_impl.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "base/memory/ptr_util.h" 10 #include "base/memory/ptr_util.h"
(...skipping 107 matching lines...) Expand 10 before | Expand all | Expand 10 after
118 WebServiceWorkerRegistrationImpl::proxy() { 118 WebServiceWorkerRegistrationImpl::proxy() {
119 return proxy_; 119 return proxy_;
120 } 120 }
121 121
122 blink::WebURL WebServiceWorkerRegistrationImpl::scope() const { 122 blink::WebURL WebServiceWorkerRegistrationImpl::scope() const {
123 return handle_ref_->scope(); 123 return handle_ref_->scope();
124 } 124 }
125 125
126 void WebServiceWorkerRegistrationImpl::update( 126 void WebServiceWorkerRegistrationImpl::update(
127 blink::WebServiceWorkerProvider* provider, 127 blink::WebServiceWorkerProvider* provider,
128 WebServiceWorkerUpdateCallbacks* callbacks) { 128 std::unique_ptr<WebServiceWorkerUpdateCallbacks> callbacks) {
129 WebServiceWorkerProviderImpl* provider_impl = 129 WebServiceWorkerProviderImpl* provider_impl =
130 static_cast<WebServiceWorkerProviderImpl*>(provider); 130 static_cast<WebServiceWorkerProviderImpl*>(provider);
131 ServiceWorkerDispatcher* dispatcher = 131 ServiceWorkerDispatcher* dispatcher =
132 ServiceWorkerDispatcher::GetThreadSpecificInstance(); 132 ServiceWorkerDispatcher::GetThreadSpecificInstance();
133 DCHECK(dispatcher); 133 DCHECK(dispatcher);
134 dispatcher->UpdateServiceWorker(provider_impl->provider_id(), 134 dispatcher->UpdateServiceWorker(provider_impl->provider_id(),
135 registrationId(), callbacks); 135 registrationId(), std::move(callbacks));
136 } 136 }
137 137
138 void WebServiceWorkerRegistrationImpl::unregister( 138 void WebServiceWorkerRegistrationImpl::unregister(
139 blink::WebServiceWorkerProvider* provider, 139 blink::WebServiceWorkerProvider* provider,
140 WebServiceWorkerUnregistrationCallbacks* callbacks) { 140 std::unique_ptr<WebServiceWorkerUnregistrationCallbacks> callbacks) {
141 WebServiceWorkerProviderImpl* provider_impl = 141 WebServiceWorkerProviderImpl* provider_impl =
142 static_cast<WebServiceWorkerProviderImpl*>(provider); 142 static_cast<WebServiceWorkerProviderImpl*>(provider);
143 ServiceWorkerDispatcher* dispatcher = 143 ServiceWorkerDispatcher* dispatcher =
144 ServiceWorkerDispatcher::GetThreadSpecificInstance(); 144 ServiceWorkerDispatcher::GetThreadSpecificInstance();
145 DCHECK(dispatcher); 145 DCHECK(dispatcher);
146 dispatcher->UnregisterServiceWorker(provider_impl->provider_id(), 146 dispatcher->UnregisterServiceWorker(provider_impl->provider_id(),
147 registrationId(), callbacks); 147 registrationId(), std::move(callbacks));
148 } 148 }
149 149
150 void WebServiceWorkerRegistrationImpl::enableNavigationPreload( 150 void WebServiceWorkerRegistrationImpl::enableNavigationPreload(
151 bool enable, 151 bool enable,
152 blink::WebServiceWorkerProvider* provider, 152 blink::WebServiceWorkerProvider* provider,
153 std::unique_ptr<WebEnableNavigationPreloadCallbacks> callbacks) { 153 std::unique_ptr<WebEnableNavigationPreloadCallbacks> callbacks) {
154 WebServiceWorkerProviderImpl* provider_impl = 154 WebServiceWorkerProviderImpl* provider_impl =
155 static_cast<WebServiceWorkerProviderImpl*>(provider); 155 static_cast<WebServiceWorkerProviderImpl*>(provider);
156 ServiceWorkerDispatcher* dispatcher = 156 ServiceWorkerDispatcher* dispatcher =
157 ServiceWorkerDispatcher::GetThreadSpecificInstance(); 157 ServiceWorkerDispatcher::GetThreadSpecificInstance();
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
209 } 209 }
210 210
211 WebServiceWorkerRegistrationImpl::~WebServiceWorkerRegistrationImpl() { 211 WebServiceWorkerRegistrationImpl::~WebServiceWorkerRegistrationImpl() {
212 ServiceWorkerDispatcher* dispatcher = 212 ServiceWorkerDispatcher* dispatcher =
213 ServiceWorkerDispatcher::GetThreadSpecificInstance(); 213 ServiceWorkerDispatcher::GetThreadSpecificInstance();
214 if (dispatcher) 214 if (dispatcher)
215 dispatcher->RemoveServiceWorkerRegistration(handle_ref_->handle_id()); 215 dispatcher->RemoveServiceWorkerRegistration(handle_ref_->handle_id());
216 } 216 }
217 217
218 } // namespace content 218 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698