Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1350)

Unified Diff: content/child/service_worker/web_service_worker_provider_impl.h

Issue 2480293004: Mandate unique_ptr for base::IDMap in IDMapOwnPointer mode. (Closed)
Patch Set: Make changes requested by danakj, fix a few more headers Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/child/service_worker/web_service_worker_provider_impl.h
diff --git a/content/child/service_worker/web_service_worker_provider_impl.h b/content/child/service_worker/web_service_worker_provider_impl.h
index 560a6e1929019badcbce14074b17e545ed280c17..d60a29c3c60a56680144384d557368110c7d76ce 100644
--- a/content/child/service_worker/web_service_worker_provider_impl.h
+++ b/content/child/service_worker/web_service_worker_provider_impl.h
@@ -5,6 +5,8 @@
#ifndef CONTENT_CHILD_SERVICE_WORKER_WEB_SERVICE_WORKER_PROVIDER_IMPL_H_
#define CONTENT_CHILD_SERVICE_WORKER_WEB_SERVICE_WORKER_PROVIDER_IMPL_H_
+#include <memory>
+
#include "base/compiler_specific.h"
#include "base/macros.h"
#include "base/memory/ref_counted.h"
@@ -32,14 +34,18 @@ class WebServiceWorkerProviderImpl
void setClient(blink::WebServiceWorkerProviderClient* client) override;
- void registerServiceWorker(const blink::WebURL& pattern,
- const blink::WebURL& script_url,
- WebServiceWorkerRegistrationCallbacks*) override;
- void getRegistration(const blink::WebURL& document_url,
- WebServiceWorkerGetRegistrationCallbacks*) override;
- void getRegistrations(WebServiceWorkerGetRegistrationsCallbacks*) override;
+ void registerServiceWorker(
+ const blink::WebURL& pattern,
+ const blink::WebURL& script_url,
+ std::unique_ptr<WebServiceWorkerRegistrationCallbacks>) override;
+ void getRegistration(
+ const blink::WebURL& document_url,
+ std::unique_ptr<WebServiceWorkerGetRegistrationCallbacks>) override;
+ void getRegistrations(
+ std::unique_ptr<WebServiceWorkerGetRegistrationsCallbacks>) override;
void getRegistrationForReady(
- WebServiceWorkerGetRegistrationForReadyCallbacks*) override;
+ std::unique_ptr<WebServiceWorkerGetRegistrationForReadyCallbacks>)
+ override;
bool validateScopeAndScriptURL(const blink::WebURL& pattern,
const blink::WebURL& script_url,
blink::WebString* error_message) override;

Powered by Google App Engine
This is Rietveld 408576698