Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3820)

Unified Diff: chrome/browser/permissions/permission_manager.cc

Issue 2480293004: Mandate unique_ptr for base::IDMap in IDMapOwnPointer mode. (Closed)
Patch Set: Fix typo breaking a bunch of trybot builds, oops Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/permissions/permission_manager.cc
diff --git a/chrome/browser/permissions/permission_manager.cc b/chrome/browser/permissions/permission_manager.cc
index 9b54d1561e26c849784bc26e3e3bdc83f83db3b5..683d149be875fd32b87729296a33f1eb2f08cf1a 100644
--- a/chrome/browser/permissions/permission_manager.cc
+++ b/chrome/browser/permissions/permission_manager.cc
@@ -300,9 +300,9 @@ int PermissionManager::RequestPermissions(
content::WebContents::FromRenderFrameHost(render_frame_host);
GURL embedding_origin = web_contents->GetLastCommittedURL().GetOrigin();
- PendingRequest* pending_request = new PendingRequest(
- render_frame_host, permissions, callback);
- int request_id = pending_requests_.Add(pending_request);
+ int request_id = pending_requests_.Add(
+ base::MakeUnique<PendingRequest>(
+ render_frame_host, permissions, callback));
const PermissionRequestID request(render_frame_host, request_id);
@@ -444,7 +444,7 @@ int PermissionManager::SubscribePermissionStatusChange(
subscription->embedding_origin);
}
- return subscriptions_.Add(subscription);
+ return subscriptions_.Add(std::unique_ptr<Subscription>(subscription));
danakj 2016/11/18 00:15:32 make the var a unique_ptr?
}
void PermissionManager::UnsubscribePermissionStatusChange(int subscription_id) {

Powered by Google App Engine
This is Rietveld 408576698