Mandate unique_ptr for base::IDMap in IDMapOwnPointer mode.

android_webview/browser/aw_permission_manager.cc

Index: android_webview/browser/aw_permission_manager.cc
diff --git a/android_webview/browser/aw_permission_manager.cc b/android_webview/browser/aw_permission_manager.cc
index 12a6cdd1a840377462fddf9adcff9e1515145945..2907d618aa4cfdfec7aafbc9410b2feadbf3a7ab 100644
--- a/android_webview/browser/aw_permission_manager.cc
+++ b/android_webview/browser/aw_permission_manager.cc
@@ -4,6 +4,7 @@
 
 #include "android_webview/browser/aw_permission_manager.h"
 
+#include <memory>
 #include <string>
 
 #include "android_webview/browser/aw_browser_permission_request_delegate.h"
@@ -275,7 +276,8 @@ int AwPermissionManager::RequestPermissions(
     }
   }
 
-  int request_id = pending_requests_.Add(pending_request);
+  int request_id = pending_requests_.Add(
+      std::unique_ptr<PendingRequest>(pending_request));

[danakj, 2016/11/18 00:15:32]

base::WrapUnique?

Tho it'd be nicer to allocate into a unique_ptr above and store a raw pointer
separately. That avoids dangers of double-free by wrapping more than once.

 
   AwBrowserPermissionRequestDelegate* delegate = GetDelegate(
       pending_request->render_process_id, pending_request->render_frame_id);