Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Issue 2480273002: Reland of [testing/script] Switch run_telemetry_as_googletest.py to produce full json results format (Closed)

Created:
4 years, 1 month ago by nednguyen
Modified:
4 years, 1 month ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of [testing/script] Switch run_telemetry_as_googletest.py to produce full json results format (patchset #1 id:1 of https://codereview.chromium.org/2408043002/ ) Reason for revert: Mac 10.10 Tests & Mac 10.11 Tests are now swarmed: https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.10%20Tests/builds/8831 https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.11%20Tests/builds/3344 Original issue's description: > Revert of [testing/script] Switch run_telemetry_as_googletest.py to produce full json results format (patchset #2 id:20001 of https://codereview.chromium.org/2403913002/ ) > > Reason for revert: > Speculatively reverting this patch (suggested by findit) to see if it fixes Mac telemetry unit tests. > > https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.10%20Tests/builds/8276 > > https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.10%20Tests/builds/8277 > > Original issue's description: > > [testing/script] Switch run_telemetry_as_googletest.py to produce full json results format > > > > BUG=649762 > > > > Committed: https://crrev.com/caa3b797728c9337fcea7d108a087d005fa7f451 > > Cr-Commit-Position: refs/heads/master@{#424206} > > TBR=kbr@chromium.org,dpranke@chromium.org,nednguyen@google.com > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=649762 > > Committed: https://crrev.com/12b54d66ba1ce9e7a6c729fdf136b5b5c257b6f2 > Cr-Commit-Position: refs/heads/master@{#424341} TBR=kbr@chromium.org,dpranke@chromium.org,loyso@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=649762 Committed: https://crrev.com/31c541dea4737f0b5a112d235e5cdebcea18d0bb Cr-Commit-Position: refs/heads/master@{#430285}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -18 lines) Patch
M testing/scripts/run_telemetry_as_googletest.py View 2 chunks +3 lines, -18 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
nednguyen
Created Reland of [testing/script] Switch run_telemetry_as_googletest.py to produce full json results format
4 years, 1 month ago (2016-11-07 15:07:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2480273002/1
4 years, 1 month ago (2016-11-07 15:07:31 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-07 16:17:23 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-07 16:42:46 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/31c541dea4737f0b5a112d235e5cdebcea18d0bb
Cr-Commit-Position: refs/heads/master@{#430285}

Powered by Google App Engine
This is Rietveld 408576698